Skip to content

Fixing keyword args in top-level pm.compile_fn #5865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Fixing keyword args in top-level pm.compile_fn #5865

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ba6cdab
Fixing keyword args in top-level pm.compile_fn
dfm Jun 7, 2022
6d6a1e8
Adding test for compile_fn
dfm Jun 8, 2022
03df281
Executing test in model context
dfm Jun 8, 2022
84dc7b4
Maybe compile_fn only accepts a single variable
dfm Jun 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pymc/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1825,7 +1825,7 @@ def compile_fn(outs, mode=None, point_fn=True, model=None, **kwargs):
Compiled Aesara function as point function.
"""
model = modelcontext(model)
return model.compile_fn(outs, mode, point_fn=point_fn, **kwargs)
return model.compile_fn(outs, mode=mode, point_fn=point_fn, **kwargs)


def Point(*args, filter_model_vars=False, **kwargs) -> Dict[str, np.ndarray]:
Expand Down
19 changes: 19 additions & 0 deletions pymc/tests/test_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -966,3 +966,22 @@ def test_deterministic():

def test_empty_model_representation():
assert pm.Model().str_repr() == ""


def test_compile_fn():
with pm.Model() as m:
x = pm.Normal("x", 0, 1, size=2)
y = pm.LogNormal("y", 0, 1, size=2)

test_vals = np.array([0.0, -1.0])
state = {"x": test_vals, "y_log__": test_vals}

for target in [x, y]:
Copy link
Member

@ricardoV94 ricardoV94 Jun 8, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that should be the case :P (that it only accepts one output). Did we introduce that constraint somewhere by accident?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure - it's still not working with a strange error message!

with m:
func = pm.compile_fn(target)
result_compute = func(state)

func = m.compile_fn(target)
result_expect = func(state)

np.testing.assert_allclose(result_compute, result_expect)