Rename TensorType's broadcastable constructor keyword argument to shape
#5350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
reviewed
Jan 13, 2022
| accu = aesara.shared( | ||
| np.zeros(value.shape, dtype=value.dtype), broadcastable=param.broadcastable | ||
| ) | ||
| accu = aesara.shared(np.zeros(value.shape, dtype=value.dtype), shape=param.broadcastable) |
There was a problem hiding this comment.
Suggested change
| accu = aesara.shared(np.zeros(value.shape, dtype=value.dtype), shape=param.broadcastable) | |
| accu = aesara.shared(np.zeros(value.shape, dtype=value.dtype), shape=param.shape) |
?
There was a problem hiding this comment.
Yes, but we don't need to make those kinds of changes (yet), because shape is backward compatible with broadcastable (i.e. it takes a list of bools that yields the same results).
|
I believe that this PR is entirely included in #6059. Sorry, I am just discovering this draft PR. |
|
Perfect! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes necessary changes in response to aesara-devs/aesara#711. It won't pass until the next minor version release is made containing the changes from aesara-devs/aesara#711.