Add moment for Simulator distribution #5208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 tasks
Codecov Report
@@ Coverage Diff @@
## main #5208 +/- ##
=======================================
Coverage 77.98% 77.98%
=======================================
Files 88 88
Lines 14215 14220 +5
=======================================
+ Hits 11085 11090 +5
Misses 3130 3130
|
aloctavodia
approved these changes
Nov 19, 2021
Member
aloctavodia
left a comment
aloctavodia
left a comment
There was a problem hiding this comment.
That seems to be a reasonable heuristic
twiecki
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5078
I went with a simple heuristic: the mean of 10 draws.
This is all very experimental, because we haven't really investigated how unobserved Simulators work and much less how they work outside of SMC where the moment would be used.
@aloctavodia what do you think?