Duplicated `initial_point` method

[williambdean]

Description of your problem

The initial_point method for the Model class shows up twice.

pymc/pymc/model.py

Lines 998 to 1007 in 5d7283e

	def initial_point(self, seed=None) -> Dict[str, np.ndarray]:
	"""Computes the initial point of the model.
	Returns
	-------
	ip : dict
	Maps names of transformed variables to numeric initial values in the transformed space.
	"""
	fn = make_initial_point_fn(model=self, return_transformed=True)
	return Point(fn(seed), model=self)

pymc/pymc/model.py

Lines 1262 to 1271 in 5d7283e

	def initial_point(self, seed=None) -> Dict[str, np.ndarray]:
	"""Computes the initial point of the model.
	Returns
	-------
	ip : dict
	Maps names of transformed variables to numeric initial values in the transformed space.
	"""
	fn = make_initial_point_fn(model=self, return_transformed=True)
	return Point(fn(seed), model=self)

Please provide any additional information below.

Seems to be a mistake.

Another side note, the seed parameter seems to be inconsistent with many of the other methods using random_seed named argument.

Versions and main components

• PyMC/PyMC3 Version: 4.3.0
• Aesara/Theano Version:
• Python Version:
• Operating system:
• How did you install PyMC/PyMC3: (conda/pip)

[ricardoV94]

I think I just fixed that... let me check...

Edit: Nope, I removed another property that was duplicated not this one.

[ricardoV94]

@wd60622 Would you like to open a PR to fix it?

We can rename seed to random_seed, but even more useful would be to add a type hint for what is actually allowed. I think it accepts less types than the other pymc sampling functions...

[williambdean]

@wd60622 Would you like to open a PR to fix it?

We can rename seed to random_seed, but even more useful would be to add a type hint for what is actually allowed. I think it accepts less types than the other pymc sampling functions...

Sure thing. I will remove the duplication and add to type hints / docstring

[ricardoV94]

Also worth checking we don't have any other duplications xD

[williambdean]

Also worth checking we don't have any other duplications xD

Will check for functionality in the linter

[williambdean]

Interestingly enough, used pyflakes and only seems to be in this file lol. I will address them all

(linter) ➜  pymc git:(duplicate_initial_point_method) python -m pyflakes pymc | grep "redefinition"
pymc/model.py:1262:5: redefinition of unused 'initial_point' from line 998
pymc/model.py:1274:5: redefinition of unused 'initial_values' from line 1010
pymc/model.py:1282:5: redefinition of unused 'set_initval' from line 1018