Skip to content

make random sample match variable shape #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2023
Merged

make random sample match variable shape #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pymc_bart/bart.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def rng_fn(cls, rng=None, X=None, Y=None, m=None, alpha=None, split_prior=None,
else:
return np.full(cls.Y.shape[0], cls.Y.mean())
else:
return _sample_posterior(cls.all_trees, cls.X, rng=rng).squeeze()
return _sample_posterior(cls.all_trees, cls.X, rng=rng).squeeze().T


bart = BARTRV()
Expand Down
13 changes: 13 additions & 0 deletions tests/test_bart.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,19 @@ def test_shared_variable():
assert ppc2.posterior_predictive["y"].shape == (2, 100, 3)


def test_shape():
X = np.random.normal(0, 1, size=(250, 3))
Y = np.random.normal(0, 1, size=250)

with pm.Model() as model:
w = pmb.BART("w", X, Y, m=2, shape=(2, 250))
y = pm.Normal("y", w[0], pm.math.abs(w[1]), observed=Y)
idata = pm.sample(random_seed=3415)

assert model.initial_point()["w"].shape == (2, 250)
assert idata.posterior.coords["w_dim_0"].data.size == 2
assert idata.posterior.coords["w_dim_1"].data.size == 250

class TestUtils:
X_norm = np.random.normal(0, 1, size=(50, 2))
X_binom = np.random.binomial(1, 0.5, size=(50, 1))
Expand Down