Skip to content

Fix FP for possibly-used-before-assignment with assert_never() #9645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2024
Merged

Fix FP for possibly-used-before-assignment with assert_never() #9645

merged 1 commit into from
May 18, 2024

Conversation

@jacobtylerwalls
Copy link
Member

@jacobtylerwalls jacobtylerwalls commented May 18, 2024

Type of Changes

Type
βœ“ πŸ› Bug fix

Description

Closes #9643

Thanks @efroemling for the report and test case.

@jacobtylerwalls jacobtylerwalls added False Positive 🦟 A message is emitted but nothing is wrong with the code backport maintenance/4.0.x labels May 18, 2024
@jacobtylerwalls jacobtylerwalls added this to the 3.2.1 milestone May 18, 2024
@codecov
Copy link

codecov bot commented May 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 95.84%. Comparing base (fbc1ed3) to head (8b1aab1).
Report is 163 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9645   +/-   ##
=======================================
  Coverage   95.84%   95.84%           
=======================================
  Files         174      174           
  Lines       18896    18900    +4     
=======================================
+ Hits        18110    18114    +4     
  Misses        786      786
Files Coverage Ξ”
pylint/checkers/variables.py 97.36% <100.00%> (+<0.01%) ⬆️
pylint/constants.py 100.00% <100.00%> (ΓΈ)

@github-actions
Copy link
Contributor

github-actions bot commented May 18, 2024

πŸ€– Effect of this PR on checked open source code: πŸ€–

Effect on pytest:
The following messages are no longer emitted:

  1. possibly-used-before-assignment:
    Possibly using variable 'scoped_item_path' before assignment
    https://github.com/pytest-dev/pytest/blob/fdf3aa3fc35ee6d336eafef5016f308b5e57bddb/src/_pytest/fixtures.py#L201

This comment was generated for commit 8b1aab1

@jacobtylerwalls jacobtylerwalls merged commit 117be95 into main May 18, 2024
@jacobtylerwalls jacobtylerwalls deleted the uba-assert-never branch May 18, 2024 13:32
github-actions bot pushed a commit that referenced this pull request May 18, 2024
@jacobtylerwalls @github-actions
Fix FP for possibly-used-before-assignment with assert_never() (#…
046db3f 
…9645)

(cherry picked from commit 117be95)
@github-actions github-actions bot mentioned this pull request May 18, 2024
Merged
Pierre-Sassoulas added a commit that referenced this pull request May 18, 2024
@github-actions @jacobtylerwalls @Pierre-Sassoulas
Fix FP for possibly-used-before-assignment with assert_never() (#…
aed496a 
…9645) (#9647)

(cherry picked from commit 117be95)

Co-authored-by: Jacob Walls <[email protected]>
Co-authored-by: Pierre Sassoulas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees

No one assigned

Labels

Backported False Positive 🦟 A message is emitted but nothing is wrong with the code

Projects

None yet

Milestone

3.2.1

Development

Successfully merging this pull request may close these issues.

possibly-used-before-assignment does not understand assert_never

3 participants

@jacobtylerwalls @Pierre-Sassoulas