Enhanced support for @Property decorator in pyreverse #10057

Julfried · 2024-10-30T14:53:29Z

Type of Changes

	Type
✓	✨ New feature

Description

Closes #9212

Closes #7644

Fixed by properly extracting the return types when handling class attributes. Implementation is much cleaner than before.

This reverts commit a707767. Revert "Extract return types for property decorator" This reverts commit 9962519.

…rties

codecov · 2025-03-02T21:59:07Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.86%. Comparing base (1e08448) to head (52880d3).
Report is 141 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #10057   +/-   ##
=======================================
  Coverage   95.86%   95.86%           
=======================================
  Files         175      175           
  Lines       19069    19072    +3     
=======================================
+ Hits        18281    18284    +3     
  Misses        788      788

Files with missing lines	Coverage Δ
pylint/pyreverse/diagrams.py	`93.47% <100.00%> (+0.14%)`	⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

github-actions · 2025-03-02T22:14:22Z

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit 8ff2fdd

Julfried · 2025-03-03T21:02:02Z

@Pierre-Sassoulas I cleaned up my previous solution and have it actually working, when there is a property that has a return type annotated. However if there is no return type annotated it does not work, so the current test structure in tests/data isn`t ideal for testing this. Changing the structure however would require updating all the resulting diagrams. Not sure if I should do that?

Julfried · 2025-03-03T21:02:24Z

pylint/pyreverse/diagrams.py

+            ) and decorated_with_property(associated_nodes):
+                if associated_nodes.returns:
+                    type_annotation = get_annotation_label(associated_nodes.returns)
+                    node_name = f"{node_name} : {type_annotation}"


I am not that experienced, but do you think it is possible to infer the return type using astroid in case the property is not annotated? In essence add an else branch in here

In pylint we infer only and do not trust the typing (because there was no typing when pylint was created), so yes. Not sure what the philosophy in pyreverse should be. Probably that trusting the typing first then inferring makes sense (even if changing the philosophy in pylint would be humongous work and probably make pylint inconsistent).

I think this philosophy makes sense. Also assumed that pylint works that way, this is why I tried to come up with a solution using node.infer_call_result() however I always got UNINFERABLE. Probalby it is an error on my side, because I have not that much experience with astroid :)

I'm not surprised you're getting uninferable, property inferring in pylint is not very good. Making property inference in astroid better would help in both pyreverse and pylint but no one worked on it as of today.

Makes a lot of sense. So I guess for now relying on the annotations for the Properties is fine. Unfortunately I currently dont have the time to work on that myself. Maybe something to work on in a follow up PR

Julfried · 2025-03-06T16:15:58Z

I guess we could fix coverage by annotating the the properties under tests/data/property_pattern.py. However this would mean I need to update all the test files. Maybe updating this files should be automated somehow?

DudeNr33 · 2025-03-06T17:18:02Z

I guess we could fix coverage by annotating the the properties under tests/data/property_pattern.py. However this would mean I need to update all the test files. Maybe updating this files should be automated somehow?

You can try using the functional tests for pyreverse. You can add new files and expected outputs below this folder: https://github.com/pylint-dev/pylint/tree/main/tests/pyreverse/functional/class_diagrams

They are picked up automatically, and the output generated by pyreverse is compared to the reference output.
If you need special command line options, or want to control what output format to create, you can create an .rc file to configure pyreverse like this: https://github.com/pylint-dev/pylint/blob/main/tests/pyreverse/functional/class_diagrams/colorized_output/colorized.rc

Julfried · 2025-03-06T18:34:07Z

Thats nice, I did not know that, Then I will use this for testing :)

Julfried · 2025-03-07T18:45:27Z

I think the pypy error is not related to my changes

DudeNr33

I feel like putting both functional tests (annotated and not annotated) into a single file fits more with the current 'one functional test file per feature/behavior', but that is personal preference. 🙂 Otherwise looks good, thanks for the fix. Let's see if adding a newsfragment also fixes the PyPy problem, as simply re-running the job did not help.

Julfried · 2025-03-10T09:49:33Z

Added a newsfragment and merged it into 1 file. Pypy action is still failing though

Pierre-Sassoulas · 2025-03-10T10:56:38Z

Don't bother with pypi3.10 it's failing on main too :)

DudeNr33

Thanks again for fixing this issue!

This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [pylint](https://github.com/pylint-dev/pylint) ([changelog](https://pylint.readthedocs.io/en/latest/whatsnew/3/)) | `<4.0.0,>=3.3.3` -> `<4.1.0,>=4.0.0` | [![age](https://developer.mend.io/api/mc/badges/age/pypi/pylint/4.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/pylint/3.3.9/4.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pylint-dev/pylint (pylint)</summary> ### [`v4.0.0`](https://github.com/pylint-dev/pylint/releases/tag/v4.0.0) [Compare Source](pylint-dev/pylint@v3.3.9...v4.0.0) - Pylint now supports Python 3.14. - Pylint's inference engine (`astroid`) is now much more precise, understanding implicit booleanness and ternary expressions. (Thanks [@zenlyj](https://github.com/zenlyj)!) Consider this example: ```python class Result: errors: dict | None = None result = Result() if result.errors: result.errors[field_key] ### inference engine understands result.errors cannot be None ### pylint no longer raises unsubscriptable-object ``` The required `astroid` version is now 4.0.0. See the [astroid changelog](https://pylint.readthedocs.io/projects/astroid/en/latest/changelog.html#what-s-new-in-astroid-4-0-0) for additional fixes, features, and performance improvements applicable to pylint. - Handling of `invalid-name` at the module level was patchy. Now, module-level constants that are reassigned are treated as variables and checked against `--variable-rgx` rather than `--const-rgx`. Module-level lists, sets, and objects can pass against either regex. Here, `LIMIT` is reassigned, so pylint only uses `--variable-rgx`: ```python LIMIT = 500 # [invalid-name] if sometimes: LIMIT = 1 # [invalid-name] ``` If this is undesired, refactor using *exclusive* assignment so that it is evident that this assignment happens only once: ```python if sometimes: LIMIT = 1 else: LIMIT = 500 # exclusive assignment: uses const regex, no warning ``` Lists, sets, and objects still pass against either `const-rgx` or `variable-rgx` even if reassigned, but are no longer completely skipped: ```python MY_LIST = [] my_list = [] My_List = [] # [invalid-name] ``` Remember to adjust the [regexes](https://pylint.readthedocs.io/en/latest/user_guide/messages/convention/invalid-name.html) and [allow lists](https://pylint.readthedocs.io/en/latest/user_guide/configuration/all-options.html#good-names) to your liking. ## Breaking Changes - `invalid-name` now distinguishes module-level constants that are assigned only once from those that are reassigned and now applies `--variable-rgx` to the latter. Values other than literals (lists, sets, objects) can pass against either the constant or variable regexes (e.g. "LOGGER" or "logger" but not "LoGgEr"). Remember that `--good-names` or `--good-names-rgxs` can be provided to explicitly allow good names. Closes [#3585](pylint-dev/pylint#3585) - The unused `pylintrc` argument to `PyLinter.__init__()` is deprecated and will be removed. Refs [#6052](pylint-dev/pylint#6052) - Commented out code blocks such as `# bar() # TODO: remove dead code` will no longer emit `fixme`. Refs [#9255](pylint-dev/pylint#9255) - `pyreverse` `Run` was changed to no longer call `sys.exit()` in its `__init__`. You should now call `Run(args).run()` which will return the exit code instead. Having a class that always raised a `SystemExit` exception was considered a bug. Normal usage of pyreverse through the CLI will not be affected by this change. Refs [#9689](pylint-dev/pylint#9689) - The `suggestion-mode` option was removed, as pylint now always emits user-friendly hints instead of false-positive error messages. You should remove it from your conf if it's defined. Refs [#9962](pylint-dev/pylint#9962) - The `async.py` checker module has been renamed to `async_checker.py` since `async` is a Python keyword and cannot be imported directly. This allows for better testing and extensibility of the async checker functionality. Refs [#10071](pylint-dev/pylint#10071) - The message-id of `continue-in-finally` was changed from `E0116` to `W0136`. The warning is now emitted for every Python version since it will raise a syntax warning in Python 3.14. See [PEP 765 - Disallow return/break/continue that exit a finally block](https://peps.python.org/pep-0765/). Refs [#10480](pylint-dev/pylint#10480) - Removed support for `nmp.NaN` alias for `numpy.NaN` being recognized in ':ref:`nan-comparison`'. Use `np` or `numpy` instead. Refs [#10583](pylint-dev/pylint#10583) - Version requirement for `isort` has been bumped to >=5.0.0. The internal compatibility for older `isort` versions exposed via `pylint.utils.IsortDriver` has been removed. Refs [#10637](pylint-dev/pylint#10637) ## New Features - `comparison-of-constants` now uses the unicode from the ast instead of reformatting from the node's values preventing some bad formatting due to `utf-8` limitation. The message now uses `"` instead of `'` to better work with what the python ast returns. Refs [#8736](pylint-dev/pylint#8736) - Enhanced pyreverse to properly distinguish between UML relationship types (association, aggregation, composition) based on object ownership semantics. Type annotations without assignment are now treated as associations, parameter assignments as aggregations, and object instantiation as compositions. Closes [#9045](pylint-dev/pylint#9045) Closes [#9267](pylint-dev/pylint#9267) - The `fixme` check can now search through docstrings as well as comments, by using `check-fixme-in-docstring = true` in the `[tool.pylint.miscellaneous]` section. Closes [#9255](pylint-dev/pylint#9255) - The `use-implicit-booleaness-not-x` checks now distinguish between comparisons used in boolean contexts and those that are not, enabling them to provide more accurate refactoring suggestions. Closes [#9353](pylint-dev/pylint#9353) - The verbose option now outputs the filenames of the files that have been checked. Previously, it only included the number of checked and skipped files. Closes [#9357](pylint-dev/pylint#9357) - colorized reporter now colorizes messages/categories that have been configured as `fail-on` in red inverse. This makes it easier to quickly find the errors that are causing pylint CI job failures. Closes [#9898](pylint-dev/pylint#9898) - Enhanced support for [@property](https://github.com/property) decorator in pyreverse to correctly display return types of annotated properties when generating class diagrams. Closes [#10057](pylint-dev/pylint#10057) - Add --max-depth option to pyreverse to control diagram complexity. A depth of 0 shows only top-level packages, 1 shows one level of subpackages, etc. This helps manage visualization of large codebases by limiting the depth of displayed packages and classes. Refs [#10077](pylint-dev/pylint#10077) - Handle deferred evaluation of annotations in Python 3.14. Closes [#10149](pylint-dev/pylint#10149) - Enhanced pyreverse to properly detect aggregations for comprehensions (list, dict, set, generator). Closes [#10236](pylint-dev/pylint#10236) - `pyreverse`: add support for colorized output when using output format `mmd` (MermaidJS) and `html`. Closes [#10242](pylint-dev/pylint#10242) - pypy 3.11 is now officially supported. Refs [#10287](pylint-dev/pylint#10287) - Add support for Python 3.14. Refs [#10467](pylint-dev/pylint#10467) - Add naming styles for `ParamSpec` and `TypeVarTuple` that align with the `TypeVar` style. Refs [#10541](pylint-dev/pylint#10541) ## New Checks - Add `match-statements` checker and the following message: `bare-name-capture-pattern`. This will emit an error message when a name capture pattern is used in a match statement which would make the remaining patterns unreachable. This code is a SyntaxError at runtime. Closes [#7128](pylint-dev/pylint#7128) - Add new check `async-context-manager-with-regular-with` to detect async context managers used with regular `with` statements instead of `async with`. Refs [#10408](pylint-dev/pylint#10408) - Add `break-in-finally` warning. Using `break` inside the `finally` clause will raise a syntax warning in Python 3.14. See `PEP 765 - Disallow return/break/continue that exit a finally block <https://peps.python.org/pep-0765/>`\_. Refs [#10480](pylint-dev/pylint#10480) - Add new checks for invalid uses of class patterns in :keyword:`match`. - :ref:`invalid-match-args-definition` is emitted if :py:data:`object.__match_args__` isn't a tuple of strings. - :ref:`too-many-positional-sub-patterns` if there are more positional sub-patterns than specified in :py:data:`object.__match_args__`. - :ref:`multiple-class-sub-patterns` if there are multiple sub-patterns for the same attribute. Refs [#10559](pylint-dev/pylint#10559) - Add additional checks for suboptimal uses of class patterns in :keyword:`match`. - :ref:`match-class-bind-self` is emitted if a name is bound to `self` instead of using an `as` pattern. - :ref:`match-class-positional-attributes` is emitted if a class pattern has positional attributes when keywords could be used. Refs [#10587](pylint-dev/pylint#10587) - Add a `consider-math-not-float` message. `float("nan")` and `float("inf")` are slower than their counterpart `math.inf` and `math.nan` by a factor of 4 (notwithstanding the initial import of math) and they are also not well typed when using mypy. This check also catches typos in float calls as a side effect. The :ref:`pylint.extensions.code_style` need to be activated for this check to work. Refs [#10621](pylint-dev/pylint#10621) ## False Positives Fixed - Fix a false positive for `used-before-assignment` when a variable defined under an `if` and via a named expression (walrus operator) is used later when guarded under the same `if` test. Closes [#10061](pylint-dev/pylint#10061) - Fix :ref:`no-name-in-module` for members of `concurrent.futures` with Python 3.14. Closes [#10632](pylint-dev/pylint#10632) ## False Negatives Fixed - Fix false negative for `used-before-assignment` when a `TYPE_CHECKING` import is used as a type annotation prior to erroneous usage. Refs [#8893](pylint-dev/pylint#8893) - Match cases are now counted as edges in the McCabe graph and will increase the complexity accordingly. Refs [#9667](pylint-dev/pylint#9667) - Check module-level constants with type annotations for `invalid-name`. Remember to adjust `const-naming-style` or `const-rgx` to your liking. Closes [#9770](pylint-dev/pylint#9770) - Fix false negative where function-redefined (E0102) was not reported for functions with a leading underscore. Closes [#9894](pylint-dev/pylint#9894) - We now raise a `logging-too-few-args` for format string with no interpolation arguments at all (i.e. for something like `logging.debug("Awaiting process %s")` or `logging.debug("Awaiting process {pid}")`). Previously we did not raise for such case. Closes [#9999](pylint-dev/pylint#9999) - Fix false negative for `used-before-assignment` when a function is defined inside a `TYPE_CHECKING` guard block and used later. Closes [#10028](pylint-dev/pylint#10028) - Fix a false negative for `possibly-used-before-assignment` when a variable is conditionally defined and later assigned to a type-annotated variable. Closes [#10421](pylint-dev/pylint#10421) - Fix false negative for `deprecated-module` when a `__import__` method is used instead of `import` sentence. Refs [#10453](pylint-dev/pylint#10453) - Count match cases for `too-many-branches` check. Refs [#10542](pylint-dev/pylint#10542) - Fix false-negative where :ref:`unused-import` was not reported for names referenced in a preceding `global` statement. Refs [#10633](pylint-dev/pylint#10633) ## Other Bug Fixes - When displaying unicode with surrogates (or other potential `UnicodeEncodeError`), pylint will now display a '?' character (using `encode(encoding="utf-8", errors="replace")`) instead of crashing. The functional tests classes are also updated to handle this case. Closes [#8736](pylint-dev/pylint#8736) - Fixed unidiomatic-typecheck only checking left-hand side. Closes [#10217](pylint-dev/pylint#10217) - Fix a crash caused by malformed format strings when using `.format` with keyword arguments. Closes [#10282](pylint-dev/pylint#10282) - Fix false positive `inconsistent-return-statements` when using `quit()` or `exit()` functions. Closes [#10508](pylint-dev/pylint#10508) - Fix a crash in :ref:`nested-min-max` when using `builtins.min` or `builtins.max` instead of `min` or `max` directly. Closes [#10626](pylint-dev/pylint#10626) - Fixed a crash in :ref:`unnecessary-dict-index-lookup` when the index of an enumerated list was deleted inside a for loop. Closes [#10627](pylint-dev/pylint#10627) ## Other Changes - Remove support for launching pylint with Python 3.9. Code that supports Python 3.9 can still be linted with the `--py-version=3.9` setting. Refs [#10405](pylint-dev/pylint#10405) ## Internal Changes - Modified test framework to allow for different test output for different Python versions. Refs [#10382](pylint-dev/pylint#10382) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.tainton.uk/repos/roboluke/pulls/384 Co-authored-by: renovate[bot] <[email protected]> Co-committed-by: renovate[bot] <[email protected]>

This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [pylint](https://github.com/pylint-dev/pylint) ([changelog](https://pylint.readthedocs.io/en/latest/whatsnew/3/)) | `<4.0.0,>=3.3.3` -> `<4.1.0,>=4.0.0` | [![age](https://developer.mend.io/api/mc/badges/age/pypi/pylint/4.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/pylint/3.3.9/4.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pylint-dev/pylint (pylint)</summary> ### [`v4.0.0`](https://github.com/pylint-dev/pylint/releases/tag/v4.0.0) [Compare Source](pylint-dev/pylint@v3.3.9...v4.0.0) - Pylint now supports Python 3.14. - Pylint's inference engine (`astroid`) is now much more precise, understanding implicit booleanness and ternary expressions. (Thanks [@zenlyj](https://github.com/zenlyj)!) Consider this example: ```python class Result: errors: dict | None = None result = Result() if result.errors: result.errors[field_key] ### inference engine understands result.errors cannot be None ### pylint no longer raises unsubscriptable-object ``` The required `astroid` version is now 4.0.0. See the [astroid changelog](https://pylint.readthedocs.io/projects/astroid/en/latest/changelog.html#what-s-new-in-astroid-4-0-0) for additional fixes, features, and performance improvements applicable to pylint. - Handling of `invalid-name` at the module level was patchy. Now, module-level constants that are reassigned are treated as variables and checked against `--variable-rgx` rather than `--const-rgx`. Module-level lists, sets, and objects can pass against either regex. Here, `LIMIT` is reassigned, so pylint only uses `--variable-rgx`: ```python LIMIT = 500 # [invalid-name] if sometimes: LIMIT = 1 # [invalid-name] ``` If this is undesired, refactor using *exclusive* assignment so that it is evident that this assignment happens only once: ```python if sometimes: LIMIT = 1 else: LIMIT = 500 # exclusive assignment: uses const regex, no warning ``` Lists, sets, and objects still pass against either `const-rgx` or `variable-rgx` even if reassigned, but are no longer completely skipped: ```python MY_LIST = [] my_list = [] My_List = [] # [invalid-name] ``` Remember to adjust the [regexes](https://pylint.readthedocs.io/en/latest/user_guide/messages/convention/invalid-name.html) and [allow lists](https://pylint.readthedocs.io/en/latest/user_guide/configuration/all-options.html#good-names) to your liking. ## Breaking Changes - `invalid-name` now distinguishes module-level constants that are assigned only once from those that are reassigned and now applies `--variable-rgx` to the latter. Values other than literals (lists, sets, objects) can pass against either the constant or variable regexes (e.g. "LOGGER" or "logger" but not "LoGgEr"). Remember that `--good-names` or `--good-names-rgxs` can be provided to explicitly allow good names. Closes [#3585](pylint-dev/pylint#3585) - The unused `pylintrc` argument to `PyLinter.__init__()` is deprecated and will be removed. Refs [#6052](pylint-dev/pylint#6052) - Commented out code blocks such as `# bar() # TODO: remove dead code` will no longer emit `fixme`. Refs [#9255](pylint-dev/pylint#9255) - `pyreverse` `Run` was changed to no longer call `sys.exit()` in its `__init__`. You should now call `Run(args).run()` which will return the exit code instead. Having a class that always raised a `SystemExit` exception was considered a bug. Normal usage of pyreverse through the CLI will not be affected by this change. Refs [#9689](pylint-dev/pylint#9689) - The `suggestion-mode` option was removed, as pylint now always emits user-friendly hints instead of false-positive error messages. You should remove it from your conf if it's defined. Refs [#9962](pylint-dev/pylint#9962) - The `async.py` checker module has been renamed to `async_checker.py` since `async` is a Python keyword and cannot be imported directly. This allows for better testing and extensibility of the async checker functionality. Refs [#10071](pylint-dev/pylint#10071) - The message-id of `continue-in-finally` was changed from `E0116` to `W0136`. The warning is now emitted for every Python version since it will raise a syntax warning in Python 3.14. See [PEP 765 - Disallow return/break/continue that exit a finally block](https://peps.python.org/pep-0765/). Refs [#10480](pylint-dev/pylint#10480) - Removed support for `nmp.NaN` alias for `numpy.NaN` being recognized in ':ref:`nan-comparison`'. Use `np` or `numpy` instead. Refs [#10583](pylint-dev/pylint#10583) - Version requirement for `isort` has been bumped to >=5.0.0. The internal compatibility for older `isort` versions exposed via `pylint.utils.IsortDriver` has been removed. Refs [#10637](pylint-dev/pylint#10637) ## New Features - `comparison-of-constants` now uses the unicode from the ast instead of reformatting from the node's values preventing some bad formatting due to `utf-8` limitation. The message now uses `"` instead of `'` to better work with what the python ast returns. Refs [#8736](pylint-dev/pylint#8736) - Enhanced pyreverse to properly distinguish between UML relationship types (association, aggregation, composition) based on object ownership semantics. Type annotations without assignment are now treated as associations, parameter assignments as aggregations, and object instantiation as compositions. Closes [#9045](pylint-dev/pylint#9045) Closes [#9267](pylint-dev/pylint#9267) - The `fixme` check can now search through docstrings as well as comments, by using `check-fixme-in-docstring = true` in the `[tool.pylint.miscellaneous]` section. Closes [#9255](pylint-dev/pylint#9255) - The `use-implicit-booleaness-not-x` checks now distinguish between comparisons used in boolean contexts and those that are not, enabling them to provide more accurate refactoring suggestions. Closes [#9353](pylint-dev/pylint#9353) - The verbose option now outputs the filenames of the files that have been checked. Previously, it only included the number of checked and skipped files. Closes [#9357](pylint-dev/pylint#9357) - colorized reporter now colorizes messages/categories that have been configured as `fail-on` in red inverse. This makes it easier to quickly find the errors that are causing pylint CI job failures. Closes [#9898](pylint-dev/pylint#9898) - Enhanced support for [@property](https://github.com/property) decorator in pyreverse to correctly display return types of annotated properties when generating class diagrams. Closes [#10057](pylint-dev/pylint#10057) - Add --max-depth option to pyreverse to control diagram complexity. A depth of 0 shows only top-level packages, 1 shows one level of subpackages, etc. This helps manage visualization of large codebases by limiting the depth of displayed packages and classes. Refs [#10077](pylint-dev/pylint#10077) - Handle deferred evaluation of annotations in Python 3.14. Closes [#10149](pylint-dev/pylint#10149) - Enhanced pyreverse to properly detect aggregations for comprehensions (list, dict, set, generator). Closes [#10236](pylint-dev/pylint#10236) - `pyreverse`: add support for colorized output when using output format `mmd` (MermaidJS) and `html`. Closes [#10242](pylint-dev/pylint#10242) - pypy 3.11 is now officially supported. Refs [#10287](pylint-dev/pylint#10287) - Add support for Python 3.14. Refs [#10467](pylint-dev/pylint#10467) - Add naming styles for `ParamSpec` and `TypeVarTuple` that align with the `TypeVar` style. Refs [#10541](pylint-dev/pylint#10541) ## New Checks - Add `match-statements` checker and the following message: `bare-name-capture-pattern`. This will emit an error message when a name capture pattern is used in a match statement which would make the remaining patterns unreachable. This code is a SyntaxError at runtime. Closes [#7128](pylint-dev/pylint#7128) - Add new check `async-context-manager-with-regular-with` to detect async context managers used with regular `with` statements instead of `async with`. Refs [#10408](pylint-dev/pylint#10408) - Add `break-in-finally` warning. Using `break` inside the `finally` clause will raise a syntax warning in Python 3.14. See `PEP 765 - Disallow return/break/continue that exit a finally block <https://peps.python.org/pep-0765/>`\_. Refs [#10480](pylint-dev/pylint#10480) - Add new checks for invalid uses of class patterns in :keyword:`match`. - :ref:`invalid-match-args-definition` is emitted if :py:data:`object.__match_args__` isn't a tuple of strings. - :ref:`too-many-positional-sub-patterns` if there are more positional sub-patterns than specified in :py:data:`object.__match_args__`. - :ref:`multiple-class-sub-patterns` if there are multiple sub-patterns for the same attribute. Refs [#10559](pylint-dev/pylint#10559) - Add additional checks for suboptimal uses of class patterns in :keyword:`match`. - :ref:`match-class-bind-self` is emitted if a name is bound to `self` instead of using an `as` pattern. - :ref:`match-class-positional-attributes` is emitted if a class pattern has positional attributes when keywords could be used. Refs [#10587](pylint-dev/pylint#10587) - Add a `consider-math-not-float` message. `float("nan")` and `float("inf")` are slower than their counterpart `math.inf` and `math.nan` by a factor of 4 (notwithstanding the initial import of math) and they are also not well typed when using mypy. This check also catches typos in float calls as a side effect. The :ref:`pylint.extensions.code_style` need to be activated for this check to work. Refs [#10621](pylint-dev/pylint#10621) ## False Positives Fixed - Fix a false positive for `used-before-assignment` when a variable defined under an `if` and via a named expression (walrus operator) is used later when guarded under the same `if` test. Closes [#10061](pylint-dev/pylint#10061) - Fix :ref:`no-name-in-module` for members of `concurrent.futures` with Python 3.14. Closes [#10632](pylint-dev/pylint#10632) ## False Negatives Fixed - Fix false negative for `used-before-assignment` when a `TYPE_CHECKING` import is used as a type annotation prior to erroneous usage. Refs [#8893](pylint-dev/pylint#8893) - Match cases are now counted as edges in the McCabe graph and will increase the complexity accordingly. Refs [#9667](pylint-dev/pylint#9667) - Check module-level constants with type annotations for `invalid-name`. Remember to adjust `const-naming-style` or `const-rgx` to your liking. Closes [#9770](pylint-dev/pylint#9770) - Fix false negative where function-redefined (E0102) was not reported for functions with a leading underscore. Closes [#9894](pylint-dev/pylint#9894) - We now raise a `logging-too-few-args` for format string with no interpolation arguments at all (i.e. for something like `logging.debug("Awaiting process %s")` or `logging.debug("Awaiting process {pid}")`). Previously we did not raise for such case. Closes [#9999](pylint-dev/pylint#9999) - Fix false negative for `used-before-assignment` when a function is defined inside a `TYPE_CHECKING` guard block and used later. Closes [#10028](pylint-dev/pylint#10028) - Fix a false negative for `possibly-used-before-assignment` when a variable is conditionally defined and later assigned to a type-annotated variable. Closes [#10421](pylint-dev/pylint#10421) - Fix false negative for `deprecated-module` when a `__import__` method is used instead of `import` sentence. Refs [#10453](pylint-dev/pylint#10453) - Count match cases for `too-many-branches` check. Refs [#10542](pylint-dev/pylint#10542) - Fix false-negative where :ref:`unused-import` was not reported for names referenced in a preceding `global` statement. Refs [#10633](pylint-dev/pylint#10633) ## Other Bug Fixes - When displaying unicode with surrogates (or other potential `UnicodeEncodeError`), pylint will now display a '?' character (using `encode(encoding="utf-8", errors="replace")`) instead of crashing. The functional tests classes are also updated to handle this case. Closes [#8736](pylint-dev/pylint#8736) - Fixed unidiomatic-typecheck only checking left-hand side. Closes [#10217](pylint-dev/pylint#10217) - Fix a crash caused by malformed format strings when using `.format` with keyword arguments. Closes [#10282](pylint-dev/pylint#10282) - Fix false positive `inconsistent-return-statements` when using `quit()` or `exit()` functions. Closes [#10508](pylint-dev/pylint#10508) - Fix a crash in :ref:`nested-min-max` when using `builtins.min` or `builtins.max` instead of `min` or `max` directly. Closes [#10626](pylint-dev/pylint#10626) - Fixed a crash in :ref:`unnecessary-dict-index-lookup` when the index of an enumerated list was deleted inside a for loop. Closes [#10627](pylint-dev/pylint#10627) ## Other Changes - Remove support for launching pylint with Python 3.9. Code that supports Python 3.9 can still be linted with the `--py-version=3.9` setting. Refs [#10405](pylint-dev/pylint#10405) ## Internal Changes - Modified test framework to allow for different test output for different Python versions. Refs [#10382](pylint-dev/pylint#10382) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.tainton.uk/repos/epage/pulls/168 Co-authored-by: renovate[bot] <[email protected]> Co-committed-by: renovate[bot] <[email protected]>

Julfried requested a review from DudeNr33 as a code owner October 30, 2024 14:53

This comment has been minimized.

Sign in to view

Pierre-Sassoulas changed the title ~~Property decorator~~ Enhanced support for @Property decorator in pyreverse Oct 31, 2024

Julfried marked this pull request as draft December 14, 2024 23:58

Julfried added 2 commits March 2, 2025 19:18

Extract return types for property decorator

9962519

Update writer logic to also add properties to the diagram

a707767

Julfried force-pushed the property-decorator branch from a380c46 to a707767 Compare March 2, 2025 18:23

This comment has been minimized.

Sign in to view

Julfried added 2 commits March 2, 2025 22:14

Revert "Update writer logic to also add properties to the diagram"

a407835

This reverts commit a707767. Revert "Extract return types for property decorator" This reverts commit 9962519.

Implement a cleaner solution for extracting the return types of prope…

8ff2fdd

…rties

Julfried commented Mar 3, 2025

View reviewed changes

Pierre-Sassoulas added pyreverse Related to pyreverse component Enhancement ✨ Improvement to a component Needs decision 🔒 Needs a decision before implemention or rejection labels Mar 3, 2025

Add functional tests for property decorator

22249a2

Julfried marked this pull request as ready for review March 7, 2025 18:45

Pierre-Sassoulas added this to the 4.0.0 milestone Mar 9, 2025

DudeNr33 requested changes Mar 9, 2025

View reviewed changes

Julfried added 4 commits March 10, 2025 10:11

Merge into a single file

c424c3d

Add newsfragment

5d558e9

Fix newsfragment

e9a3af0

Fix file name of newsframent

52880d3

DudeNr33 approved these changes Mar 10, 2025

View reviewed changes

DudeNr33 merged commit 512c8be into pylint-dev:main Mar 10, 2025
43 of 44 checks passed

Julfried deleted the property-decorator branch March 10, 2025 20:26

Pierre-Sassoulas mentioned this pull request Oct 12, 2025

Release branch for 4.0.0 #10639

Merged

Uh oh!

Enhanced support for @Property decorator in pyreverse #10057

Enhanced support for @Property decorator in pyreverse #10057

Conversation

Julfried commented Oct 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of Changes

Description

Uh oh!

This comment has been minimized.

This comment has been minimized.

codecov bot commented Mar 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Mar 2, 2025

Uh oh!

Julfried commented Mar 3, 2025

Uh oh!

Julfried Mar 3, 2025

Choose a reason for hiding this comment

Uh oh!

Pierre-Sassoulas Mar 3, 2025

Choose a reason for hiding this comment

Uh oh!

Julfried Mar 5, 2025

Choose a reason for hiding this comment

Uh oh!

Pierre-Sassoulas Mar 5, 2025

Choose a reason for hiding this comment

Uh oh!

Julfried Mar 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Julfried commented Mar 6, 2025

Uh oh!

DudeNr33 commented Mar 6, 2025

Uh oh!

Julfried commented Mar 6, 2025

Uh oh!

Julfried commented Mar 7, 2025

Uh oh!

DudeNr33 left a comment

Choose a reason for hiding this comment

Uh oh!

Julfried commented Mar 10, 2025

Uh oh!

Pierre-Sassoulas commented Mar 10, 2025

Uh oh!

DudeNr33 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Julfried commented Oct 30, 2024 •

edited

Loading

codecov bot commented Mar 2, 2025 •

edited

Loading

Julfried Mar 6, 2025 •

edited

Loading