Skip to content

Correct typing for _sparsearray #8395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 31, 2023
Merged

Correct typing for _sparsearray #8395

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3acd853
Update _typing.py
Illviljan Oct 31, 2023
7ccee68
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 31, 2023
d9a4d0a
Update _typing.py
Illviljan Oct 31, 2023
a9c2c3b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions xarray/namedarray/_typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
from collections.abc import Hashable, Iterable, Mapping, Sequence
from types import ModuleType
from typing import (
TYPE_CHECKING,
Any,
Callable,
Protocol,
Expand All @@ -16,10 +15,6 @@

import numpy as np

if TYPE_CHECKING:
from numpy.typing import NDArray


# https://stackoverflow.com/questions/74633074/how-to-type-hint-a-generic-numpy-array
_T = TypeVar("_T")
_T_co = TypeVar("_T_co", covariant=True)
Expand Down Expand Up @@ -234,7 +229,7 @@ class _sparsearray(
Corresponds to np.ndarray.
"""

def todense(self) -> NDArray[_ScalarType_co]:
def todense(self) -> np.ndarray[Any, _DType_co]:
...


Expand Down