Skip to content

Import Bootstrap after importing our variable overrides #2066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 5, 2024
Merged

Import Bootstrap after importing our variable overrides #2066

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
078b7c6
Import Bootstrap after importing our variable overrides
gabalafou Dec 3, 2024
80f8875
Add comment
gabalafou Dec 3, 2024
260c0e1
punctuation
gabalafou Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/pydata_sphinx_theme/assets/styles/pydata-sphinx-theme.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
// Import all of Bootstrap scss
// IMPORTANT: our Bootstrap variable overrides must be imported before the
// Bootstrap files that reference those variables; otherwise our overrides will
// have no effect.
@import "variables/bootstrap";

// Import all of Bootstrap scss.
@import "~bootstrap/scss/bootstrap";

// Import FontAwesome from _node_modules
Expand All @@ -8,7 +13,6 @@
@import "~@fortawesome/fontawesome-free/scss/brands";

// Variables
@import "variables/bootstrap";
@import "variables/layout";
@import "variables/fonts";
@import "variables/icons";
Expand Down
Loading