Skip to content

Restore focus ring Sphinx Design dropdowns #2060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Restore focus ring Sphinx Design dropdowns #2060

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pydata_sphinx_theme/assets/styles/extensions/_sphinx_design.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ details.sd-dropdown {
}

// Focus ring
&:focus-visible {
&:focus:focus-visible {
Copy link
Collaborator Author

@gabalafou gabalafou Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works by increasing the specificity of the selector. If an element is :focus-visible then it is also :focus, so this changes nothing, it just allows these rules to override the focus styles in Sphinx Design.

outline: $focus-ring-outline;
outline-offset: -$focus-ring-width;
}
Expand Down
Loading