Make overlay sidebars behave like modals #1942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabalafou
commented
Jul 30, 2024
| dialog.addEventListener("click", closeDialogOnBackdropClick); | ||
|
|
||
| // We have to manually attach the escape key because there's some code in | ||
| // Sphinx's search-highlight.js that prevents the default behavior of the |
Collaborator
Author
There was a problem hiding this comment.
Need to file bug report for this. I couldn't find any existing bug report.
Collaborator
There was a problem hiding this comment.
Did you fill a bug report ? Want to reference it here ?
Collaborator
Author
There was a problem hiding this comment.
I'm working on it
Collaborator
Author
There was a problem hiding this comment.
Carreau
previously approved these changes
Aug 13, 2024
| dialog.addEventListener("click", closeDialogOnBackdropClick); | ||
|
|
||
| // We have to manually attach the escape key because there's some code in | ||
| // Sphinx's search-highlight.js that prevents the default behavior of the |
Collaborator
There was a problem hiding this comment.
Did you fill a bug report ? Want to reference it here ?
Collaborator
|
I pushed a single commit to update the tests expected case, as now one of the nodes has a |
trallard
added
the
tag: accessibility
gabalafou
commented
Aug 22, 2024
Coverage report
This PR does not seem to contain any modification to coverable code. |
This was referenced Aug 22, 2024
Collaborator
|
Ok, let's try this. |
Carreau
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very similar to #1932.
Closes external issue Quansight-Labs/czi-scientific-python-mgmt#84