Skip to content

Conversation

@trallard
Copy link
Collaborator

@trallard trallard commented Jul 1, 2024

Raised in #1906 - while this is working as is, it might be best to ensure we have all the dependencies in CI.

For more context, this comes as most people will have some of the dependencies through the installation of Playwright and browsers locally, but some might go missing in isolated CI environments.

Closes #1906

@trallard trallard added tag: dependencies Pull requests that update a dependencies or that is related to PST dependencies kind: maintenance Improving maintainability and reducing technical debt tag: CI Pull requests that update GitHub Actions code labels Jul 1, 2024
@github-actions
Copy link

github-actions bot commented Jul 1, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  src/pydata_sphinx_theme
  __init__.py
  logo.py
  short_link.py
  toctree.py
  translator.py
Project Total  

This report was generated by python-coverage-comment-action

gabalafou
gabalafou previously approved these changes Jul 2, 2024
Copy link
Collaborator

@gabalafou gabalafou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because I don't see the error message anymore in the workflow log

@trallard trallard merged commit c20f2e0 into pydata:main Jul 2, 2024
@trallard trallard deleted the trallard/add-playwright-deps branch July 2, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind: maintenance Improving maintainability and reducing technical debt tag: CI Pull requests that update GitHub Actions code tag: dependencies Pull requests that update a dependencies or that is related to PST dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

playwright install warning: missing dependencies to run browsers

2 participants