Skip to content

Scrollable table? Make keyboard accessible (focusable) #1903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Scrollable table? Make keyboard accessible (focusable) #1903

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions src/pydata_sphinx_theme/assets/scripts/pydata-sphinx-theme.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,7 +524,9 @@ function showVersionWarningBanner(data) {
const timeout_in_days = 14;
if (days_passed < timeout_in_days) {
console.info(
`[PST] Suppressing version warning banner; was dismissed ${Math.floor(days_passed)} day(s) ago`,
`[PST] Suppressing version warning banner; was dismissed ${Math.floor(
days_passed,
)} day(s) ago`,
Comment on lines +527 to +529
Copy link
Collaborator Author

@gabalafou gabalafou Jun 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-commit hook

);
return;
}
Expand Down Expand Up @@ -727,10 +729,18 @@ function addTabStopsToScrollableElements() {
const updateTabStops = () => {
document
.querySelectorAll(
"pre, " + // code blocks
".nboutput > .output_area, " + // NBSphinx notebook output
".cell_output > .output, " + // Myst-NB
".jp-RenderedHTMLCommon", // ipywidgets
[
// code blocks
"pre",
// NBSphinx notebook output
".nboutput > .output_area",
// Myst-NB
".cell_output > .output",
// ipywidgets
".jp-RenderedHTMLCommon",
// [rST table nodes](https://www.docutils.org/docs/ref/doctree.html#table)
".pst-scrollable-table-container",
].join(", "),
Comment on lines +732 to +743
Copy link
Collaborator Author

@gabalafou gabalafou Jun 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reformatted this section because when I added the new selector, .pst-scrollable-table-container, I got it wrong the first time.

)
.forEach((el) => {
el.tabIndex =
Expand Down