Error in `_overwrite_pygments_css`: DirectoryHTMLBuilder' object has no attribute 'globalcontext'

[choldgraf]

In building the documentation with Sphinx 5.3, I am occasionally getting this error message:

Handler <function _overwrite_pygments_css at 0x7f971a03caf0> for event 'build-finished' threw an exception (exception: 'DirectoryHTMLBuilder' object has no attribute 'globalcontext')

I believe it's coming from this line:

pydata-sphinx-theme/src/pydata_sphinx_theme/__init__.py

Lines 905 to 907 in 13d4692

	theme_name = app.config.html_theme_options.get(
	style_key, app.builder.globalcontext.get(f"theme_{style_key}")
	)

It still seems to be in-use by Sphinx, so not really sure what's going on:

https://github.com/sphinx-doc/sphinx/blob/ff202240abebd12b1e12c9052e11f785c401e725/sphinx/builders/html/__init__.py#L569-L573

Maybe we need to add a similar conditional?

[drammock]

hmm, hard to debug occasional failures. If you can come up with a test that fails reliably I can work on a fix. Currently I can't replicate with nox -s docs

[choldgraf]

Indeed - I found it hard to replicate as well but it happened multiple times. I figured it'd be better to capture the error message in an issue in case others come across the same problem.

If nobody else encounters this in the next 3-6 months, maybe we can just close this?

[12rambau]

fun fact since friday I got it one 1 build out of 2 systematically when building this doc: https://github.com/12rambau/sepal_ui

but only on my mac computer. I don't see the error on my linux machine. Note that to solve it I use the good old hammer technique: run it ... twice

nox -s docs

[choldgraf]

It seems like an easy fix might be to add a check for whether globalcontext exists before trying to use it. Maybe we could give that a shot and see if the intermittent errors go away

[drammock]

If it happens only on second run with no changes to the docs in between, it might be that sphinx is not fully initializing because it detects that there's nothing to build. I'll take a look on Tuesday. -------- Original Message --------

…

On Jan 9, 2023, 02:36, Chris Holdgraf wrote: It seems like an easy fix might be to add a check for whether globalcontext exists before trying to use it. Maybe we could give that a shot and see if the intermittent errors go away — Reply to this email directly, [view it on GitHub](#1096 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAN2AU5EMPWZIE4JBJJB52DWRPEX7ANCNFSM6AAAAAATOEAYOM). You are receiving this because you commented.Message ID: ***@***.***>

[drammock]

I can't replicate this (on Linux) even with @12rambau's tip of running nox -s docs twice in a row (I just ran it 3 times and all succeeded). Since he's also only able to reproduce on mac (not linux) I'm going to give up for now and go with the easy fix @choldgraf put into #1115... it's frustrating not to know why this is happening but I think the fix is probably fine/harmless even if unsatisfying.