Skip to content

Timeout not actually used #789

@JesseAldridge

Description

@JesseAldridge

I noticed my downloader hung forever. I dug through the code and it looks like the timeout parameter isn't actually passed the request call.

response = self.session.get(url, params=params, headers=headers)

Pretty sure the fix is just:

- response = self.session.get(url, params=params, headers=headers)
+ response = self.session.get(url, params=params, headers=headers, timeout=self.timeout)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions