Skip to content
This repository was archived by the owner on Sep 16, 2024. It is now read-only.

Conversation

rcolistete
Copy link
Contributor

User (External) C modules are not currently enabled in Pycom MicroPython (August 6th 2020) because 'esp32/Makefile' and 'esp32/'application.mk' don't use 'SRC_MOD', 'CFLAGS_MOD', 'LDFLAGS_MOD' and 'CFLAGS_EXTRA'.

This PR fix this issue, inserting 'SRC_MOD', 'CFLAGS_MOD', 'LDFLAGS_MOD' and 'CFLAGS_EXTRA' in correct places of 'esp32/Makefile' and 'esp32/'application.mk' so that user (external) C modules can be built when compiling the Pycom firmware.

@robert-hh
Copy link
Contributor

robert-hh commented Aug 6, 2020

Good luck with that useful PR. Pycom has a somewhat stealthy method of dealing with PR's. So your PR may sit there longtime seemingly unnoticed until eventually the content is used in a Pycom code update, honestly mentioning you.

@rcolistete
Copy link
Contributor Author

Good luck with that useful PR. Pycom has a somewhat stealthy method of dealing with PR's. So your PR may sit there longtime seemingly unnoticed until eventually the content is used in a Pycom code update, honestly mentioning you.

Hope to see this PR merged. It is very useful to allow more community contributions to Pycom MicroPython.

"pycom-micropython-sigfox/py/py.mk" already supports USER_C_MODULES, so 'SRC_MOD', 'CFLAGS_MOD' and 'LDFLAGS_MOD' are modified with content from user C modules. So it is just some lines missing in 'esp32/Makefile' and 'esp32/'application.mk' that currently blocks the use of 'user (external) C modules' in Pycom MicroPython.

@peter-pycom
Copy link
Contributor

lgmt thanks. internal PR: https://github.com/pycom/Firmware-Development/pull/175

@peter-pycom
Copy link
Contributor

Thanks again @rcolistete . It has been merged and released

X-Ryl669 pushed a commit to X-Ryl669/pycom-micropython-sigfox that referenced this pull request May 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants