Skip to content

Depend on CFFI 2.0.0 or newer on Python > 3.8 #13448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 16, 2025
Merged

Depend on CFFI 2.0.0 or newer on Python > 3.8 #13448

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e8d0aee
Depend on CFFI 2.0.0 or newer on Python > 3.8
ngoldbaum Sep 16, 2025
af36b06
fix comparison and update build_requirements.in
ngoldbaum Sep 16, 2025
baa0013
fix typo
ngoldbaum Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ requires = [
"maturin>=1.9.4,<2",

# Must be kept in sync with `project.dependencies`
"cffi>=1.14; platform_python_implementation != 'PyPy' and python_version < '3.14'",
"cffi>=2.0.0; platform_python_implementation != 'PyPy' and python_version >= '3.14'",
"cffi>=1.14; platform_python_implementation != 'PyPy' and python_version == '3.8'",
"cffi>=2.0.0; platform_python_implementation != 'PyPy' and python_version > '3.9'",
# Used by cffi (which import distutils, and in Python 3.12, distutils has
# been removed from the stdlib, but installing setuptools puts it back) as
# well as our build.rs for the rust/cffi bridge.
Expand Down Expand Up @@ -51,8 +51,8 @@ classifiers = [
requires-python = ">=3.8,!=3.9.0,!=3.9.1"
dependencies = [
# Must be kept in sync with `build-system.requires`
"cffi>=1.14; platform_python_implementation != 'PyPy' and python_version < '3.14'",
"cffi>=2.0.0; platform_python_implementation != 'PyPy' and python_version >= '3.14'",
"cffi>=1.14; platform_python_implementation != 'PyPy' and python_version == '3.8'",
"cffi>=2.0.0; platform_python_implementation != 'PyPy' and python_version > '3.9'",
Copy link
Member

@alex alex Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be >=, right?

# Must be kept in sync with ./.github/requirements/build-requirements.{in,txt}
Copy link
Member

@alex alex Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these files need to be updated for this

"typing-extensions>=4.13.2; python_version < '3.11'",
]
Expand Down
Loading