This repository was archived by the owner on Oct 4, 2020. It is now read-only.
Add foldSubmap and submap
#114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also @mtolly I think the newtype I mentioned in #113 does exist: it's |
|
Yep, looks great to me. Thanks for the help! |
paf31
reviewed
Jul 9, 2017
| foldSubmap :: forall k v m. Ord k => Monoid m => Maybe k -> Maybe k -> (k -> v -> m) -> Map k v -> m | ||
| foldSubmap kmin kmax f = | ||
| let | ||
| tooSmall = |
There was a problem hiding this comment.
Thought: you could use any here to make this a little shorter at the expense of a function call and a dictionary lookup.
|
👍 Looks great! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #71 and #113.
/cc @mtolly can you check whether this works for you? I don't think we need both an ascending and descending version because you can use Data.Monoid.Dual if you want it in the other direction.