Adding Generic instance for HugeInt

[ethul]

Would you consider accepting this PR to add a Generic instance for HugeInt?

Thanks!

[chexxor]

Should be OK, as we added Generic instances for other types in this lib - #6

[garyb]

I think maybe this should just be derive rather than derive newtype... derive newtype for Generic seems suspect to me since the derived values will be indistinguishable from the generics for the underlying type, so I don't know if they'll behave right when trying to examine/reconstruct something. I could be wrong though, if you've tried it out and it works as expected, then I guess it's fine!

[ethul]

I think you bring up a good point. Let me verify by looking at both derive by itself and derive newtype. I will provide an update on this later today or tomorrow.

[ethul]

You're right that with the newtype we get tag: "Data.HugeNum.HugeNum" instead of tag: "Data.HugeInt.HugeInt". The Generic instance with the derive newtype is working, but perhaps in the spirit of purescript-precise the second choice is a more fitting implementation. I will make the change!

[garyb]

Thanks!

[ethul]

Thank you!

…

On Fri, Feb 17, 2017 at 18:46 Gary Burgess ***@***.***> wrote: Merged #8 <#8>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#8 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVYy6nGHNP2MHDElcpTya2k65Xz7PtQks5rdjFHgaJpZM4MEpDv> .