Modify @hdgarrood's PR to use Data.Op.

[paf31]

This a slightly different take on @hdgarrood's branch, using Data.Op for Option and dropping key. As we add combinators to Data.Functor.Contravariant.Divisible, this approach will become more useful, I think.

[ethul]

Thanks! Looks good. I will dig more into this on the weekend.

On Friday, 29 January 2016, Phil Freeman [email protected] wrote:

This a slightly different take on @hdgarrood
https://github.com/hdgarrood's branch, using Data.Op for Option and
dropping key. As we add combinators to
Data.Functor.Contravariant.Divisible, this approach will become more

useful, I think.

You can view, comment on, or merge this pull request online at:

#13
Commit Summary

• Modify @hdgarrood's PR to use Data.Op.

File Changes

• M .gitignore
  https://github.com/ethul/purescript-options/pull/13/files#diff-0 (1)
• M bower.json
  https://github.com/ethul/purescript-options/pull/13/files#diff-1 (6)
• M docs/Data/Options.md
  https://github.com/ethul/purescript-options/pull/13/files#diff-2
  (82)
• D src/Data/Options.js
  https://github.com/ethul/purescript-options/pull/13/files#diff-3
  (63)
• M src/Data/Options.purs
  https://github.com/ethul/purescript-options/pull/13/files#diff-4
  (134)
• M test/Test/Main.purs
  https://github.com/ethul/purescript-options/pull/13/files#diff-5
  (46)

Patch Links:

• https://github.com/ethul/purescript-options/pull/13.patch
• https://github.com/ethul/purescript-options/pull/13.diff

—
Reply to this email directly or view it on GitHub
#13.

[ethul]

Sorry for the delay, but I think the PR looks great. Before merging, is this intended only for purescript 0.8? I am wondering if we should update the exports and corresponding imports for 0.7 compatibility? Or we could release this along with 0.8. That works for me too.

Also, do you think this module should be moved to core or contrib once this PR is merged? I am open to either.

[garyb]

Probably stick to 0.7 for now, all the core libraries are going to be updated and bumped after 0.8 is released, so it will need updating again anyway.

[ethul]

Before publishing to pursuit is this good to move into core?

[hdgarrood]

🎉

[paf31]

@ethul If you're okay with it, I think it would be a good addition. @garyb Anything else we need?

[garyb]

Nope, 👍 for moving over. Core or contrib?

[paf31]

Perhaps contrib for now, until we're confident the new API is the right one, with a view to moving it to core soonish.

[garyb]

Sounds sensible to me.

[paf31]

@ethul You should be able to move the repo to contrib now, if you like.

[ethul]

Thanks! The repo has been moved over

[paf31]

Thanks! I've set up a new team.

[ethul]

Great, thank you!

On Tuesday, 2 February 2016, Phil Freeman [email protected] wrote:

Thanks! I've set up a new team.

—
Reply to this email directly or view it on GitHub
#13 (comment)
.