Skip to content

Conversation

@maxdeviant
Copy link
Member

This PR updates purescript-now to adhere to the Contributors library guidelines.

This is part of the purescript-contrib/governance#13 effort.

@maxdeviant
Copy link
Member Author

Once this is merged we'll need issues for the following items:

  • Adding a "quick start" guide
  • Adding tests

Copy link
Contributor

@thomashoneyman thomashoneyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Since CI isn’t yet running via GitHub Actions, would you mind sharing whether the build & test commands succeed (sometimes the new eslint config will fail, for example).

@maxdeviant
Copy link
Member Author

npm run build is failing with the following error:

λ npm run build

> @ build /home/maxdeviant/projects/purescript-now
> eslint src && spago build --purs-args '--censor-lib --strict'

[info] Installation complete.
Invalid option `--censor-lib'

Usage: purs COMMAND
  The PureScript compiler and tools
[error] Failed to build.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @ build: `eslint src && spago build --purs-args '--censor-lib --strict'`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the @ build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     **/home/maxdeviant/.npm/_logs/2020-10-02T03_42_21_211Z-debug.log**

@thomashoneyman
Copy link
Contributor

That error happens when purescript-psa isn't installed. If you don't have that on your system, then try running just:

npx eslint src && spago build

@maxdeviant
Copy link
Member Author

Alright, looks like we're good!

λ npm run build

> @ build /home/maxdeviant/projects/purescript-now
> eslint src && spago build

[info] Installation complete.
[info] Build succeeded.

λ npm t

> @ test /home/maxdeviant/projects/purescript-now
> spago test --no-install

[info] Build succeeded.
🍝
You should add some tests.
[info] Tests succeeded.

@thomashoneyman
Copy link
Contributor

The issue you linked in the Governance repository has issue templates you can use to create those issues. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants