-
Notifications
You must be signed in to change notification settings - Fork 10
Add getTimezoneOffset #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add getTimezoneOffset #13
Conversation
|
|
I spotted that implementation when looking for something similar, in |
|
Yeah, the idea with the
|
|
Sorry, one more change: the duration type is called |
interesting that might be a nice challenge, going through prolonged down time so trying to keep busy 😄 |
garyb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll let @thomashoneyman merge this, as I'm not sure what we're doing with changelog and stuff with the library as it is just now!
|
Thanks @garyb, I might pose some questions on |
|
Went ahead and merged — we’ll add this to the changelog when we get to this library’s updates :) |
What does this pull request do?
add function getTimezoneOffset and fixes #8
Where should the reviewer start?
src/Effect/Now.jsHow should this be manually tested?
Other Notes:
Being this is purescript-now I used:
repl output from UK based local:
> getTimezoneOffset (Minute -60)Fell like if we'd want
Date -> Effect Minuteit might need to live inpurescript-datetime?