(CONT-807) Add Ruby 3.2 support #390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… drops support for exists. Will revisit
GSPatton
changed the title
…ated and exist is an equivalent method
… ci and nightly workflows
david22swan
reviewed
Apr 17, 2023
| ref: "2.6.0" | ||
| ``` | ||
|
|
||
| Only install the `yumrepo_core` module when testing against Puppet 6 or greater: |
Member
There was a problem hiding this comment.
Is this really necessary now that everything below Puppet 7 is unsupported?
Contributor
Author
There was a problem hiding this comment.
i originally removed all of this but thought it still had a place since it still seems relevant to >6. Seems now that this module should always be installed since all supported puppets are >6
Member
There was a problem hiding this comment.
I guess it's not a big thing
david22swan
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Ruby 3.2 support in preparation for Puppet 8 and removes Ruby 2.5 and Puppet 6 support