Skip to content

node_group type: Allow uppercase letters in environment names #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2024
Merged

node_group type: Allow uppercase letters in environment names #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/puppet/type/node_group.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def insync?(is)
desc 'Environment for this group'
defaultto :production
validate do |value|
raise('Invalid environment name') unless value =~ (%r{\A[a-z0-9_]+\Z}) || (value == 'agent-specified')
raise('Invalid environment name') unless value =~ (%r{\A[a-zA-Z0-9_]+\Z}) || (value == 'agent-specified')
end
end
newproperty(:classes) do
Expand Down
27 changes: 27 additions & 0 deletions spec/unit/puppet/type/node_group_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,33 @@
}.not_to raise_error
end

it 'allows uppercase environment name without underscore' do
expect {
Puppet::Type.type(:node_group).new(
name: 'stubname',
environment: 'ENVIRONMENTNAME',
)
}.not_to raise_error
end

it 'allows uppercase environment name with an underscore' do
expect {
Puppet::Type.type(:node_group).new(
name: 'stubname',
environment: 'ENVIRONMENT_NAME',
)
}.not_to raise_error
end

it 'allows capitalized environment name with an underscore' do
expect {
Puppet::Type.type(:node_group).new(
name: 'stubname',
environment: 'Environment_name',
)
}.not_to raise_error
end

it 'allows environment name with a number' do
expect {
Puppet::Type.type(:node_group).new(
Expand Down