Skip to content

Prevent sources with zero prefix length being applied every agent run #1189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 27, 2024
Merged

Prevent sources with zero prefix length being applied every agent run #1189

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
34592f5
Prevent sources with zero prefix length being applied every agent run
nabertrand Feb 2, 2024
c0ef42b
Merge branch 'main' into zero-lenth-prefix-source-fix
nabertrand Feb 2, 2024
68bf4e2
Merge remote-tracking branch 'origin/main' into zero-lenth-prefix-sou…
nabertrand Nov 25, 2024
7d64674
Fix rubocop warning
nabertrand Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/puppet/provider/firewall/firewall.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,8 +325,8 @@ def delete(context, name, is)
def insync?(context, _name, property_name, is_hash, should_hash)
context.debug("Checking whether '#{property_name}' is out of sync")

# If either value is nil, no custom logic is required
return nil if is_hash[property_name].nil? || should_hash[property_name].nil?
# If either value is nil, no custom logic is required unless property is source or destination
return nil if (is_hash[property_name].nil? || should_hash[property_name].nil?) && ![:source, :destination].include?(property_name)

case property_name
when :protocol
Expand Down