Add support for ScriptAliasMatch directives #502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Much like in PR puppetlabs#483 extend the _scriptalias.rb template so that the `scriptalias` parameter in `apache::vhost` can contain `aliasmatch` hashes which get translated to `ScriptAliasMatch` directives. Fixes issue puppetlabs#480. Includes basic spec tests and updated documentation in README.md. Note again that puppet-rspec silently drops `$1` when specifying test values so we match `FOO` instead of `$1`. From a simple spec test perspective there shouldn't be a difference and this is better than having no tests at all.
igalic
added a commit
that referenced
this pull request
Nov 25, 2013
Add support for ScriptAliasMatch directives
traylenator
pushed a commit
to traylenator/puppetlabs-apache
that referenced
this pull request
Jun 7, 2022
Support stdlib 6.x and apt 7.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Much like in PR #483 extend the _scriptalias.rb template so that the
scriptaliasparameter inapache::vhostcan containaliasmatchhashes which get translated to
ScriptAliasMatchdirectives. Fixesissue #480.
Includes basic spec tests and updated documentation in README.md.
Note again that puppet-rspec silently drops
$1when specifying testvalues so we match
FOOinstead of$1. From a simple spec testperspective there shouldn't be a difference and this is better than
having no tests at all.