-
Notifications
You must be signed in to change notification settings - Fork 55
(CAT-2433) Adds option to return latest agent build #596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Small issue in that I'm not sure how this will work with the pe images.... |
8f3d896
to
d2a1acd
Compare
Adds a command-line option to specify whether the latest agent build should be included in the matrix. This is due to the Mac and Windows puppet_agent install tasks requiring a specific version when installing.
Updates matrix creation logic to only include the version if requested. Introduces a check to ensure the `latest-agent` and `pe-include` options are not used simultaneously.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Were you able to run a supported module against this PR to confirm it can retrieve and install agent 8.14.0 on windows or mac?
Also to confirm, this only has a behavior change when passing the newly added argument, right? If so, then I think we can remove the backwards compatible label.
Passing 8.14.0 installs it correctly yeh, just fiddling with the action runner to make it pass neatly. |
@coreymbe Have removed the interaction between --latest-agent and --pe-include that I was worried about. |
Just pushed a quick README update |
Adds a command-line option to specify whether the latest agent build should be included in the matrix. This is due to the Mac and Windows puppet_agent install tasks requiring a specific version when installing.
This updates the passed back information to the below format:
If the latest version is not requested it will instead return in the same manor as previously, ie.
With the expectation that the user will resolve any conflicts from this on their end. This is to ensure backwards compatibility and not interfere with the work of other teams or with the specific code changes made for the pe team.
Checklist