Skip to content

(CONT-551) Fix get_exec_titles bug #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2023
Merged

(CONT-551) Fix get_exec_titles bug #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions lib/puppet-lint/plugins/check_unsafe_interpolations.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,8 @@ def get_exec_titles
# Check if title is double quotes string
elsif tokens[token_idx].next_code_token.next_code_token.type == :DQPRE
# Find the start and end of the title
title_start_idx = tokens.rindex { |r| r.type == :DQPRE }
title_end_idx = tokens.rindex { |r| r.type == :DQPOST }
title_start_idx = tokens.find_index(tokens[token_idx].next_code_token.next_code_token)
title_end_idx = title_start_idx + index_offset_for(':', tokens[title_start_idx..tokens.length])

result << tokens[title_start_idx..title_end_idx]
# Title is in single quotes
Expand All @@ -117,4 +117,13 @@ def get_exec_titles
def interpolated?(token)
INTERPOLATED_STRINGS.include?(token.type)
end

# Finds the index offset of the next instance of `value` in `tokens_slice` from the original index
def index_offset_for(value, tokens_slice)
i = 0
while i < tokens_slice.length
return i if value.include?(tokens_slice[i].value)
i += 1
end
end
end