Skip to content

(GH-958) Add Spec tests for Ruby 2.5, 2.7 on Github Actions #1030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2021
Merged

(GH-958) Add Spec tests for Ruby 2.5, 2.7 on Github Actions #1030

merged 1 commit into from
Mar 25, 2021

Conversation

@sanfrancrisko
Copy link
Contributor

@sanfrancrisko sanfrancrisko commented Mar 24, 2021 •
edited
Loading

This PR adds the following test / coverage suites to a
Github Actions workflow on both Ruby 2.5 and 2.7:

  • rubocop
  • spec:coverage
  • license_finder
  • test_pdk_as_library
  • spec

Closes: #958

@sanfrancrisko sanfrancrisko requested a review from a team as a code owner March 24, 2021 16:29
@sanfrancrisko sanfrancrisko added the maintenance Internal maintenance work that shouldn't appear in the changelog label Mar 24, 2021
da-ar
da-ar reviewed Mar 24, 2021
View reviewed changes
sanfrancrisko
sanfrancrisko commented Mar 24, 2021
View reviewed changes
@codecov
Copy link

codecov bot commented Mar 25, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@f1a720e). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 3c15a0a differs from pull request most recent head 8973251. Consider uploading reports for the commit 8973251 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1030   +/-   ##
=======================================
  Coverage        ?   91.19%           
=======================================
  Files           ?      138           
  Lines           ?     5563           
  Branches        ?        0           
=======================================
  Hits            ?     5073           
  Misses          ?      490           
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1a720e...8973251. Read the comment docs.

jpogran
jpogran reviewed Mar 25, 2021
View reviewed changes
da-ar
da-ar approved these changes Mar 25, 2021
View reviewed changes
Copy link

@da-ar da-ar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(GH-958) Add Spec tests for Ruby 2.5, 2.7 on Github Actions
8973251 
This PR adds the following test / coverage suites to a
Github Actions workflow on both Ruby 2.5 and 2.7:

- `rubocop`
- `spec:coverage`
- `license_finder`
- `test_pdk_as_library`
- `spec`
@jpogran jpogran merged commit d89cc8e into puppetlabs:main Mar 25, 2021
@sanfrancrisko sanfrancrisko deleted the GH-958/main/ghactions_spec_tests branch March 25, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@jpogran jpogran jpogran approved these changes

@da-ar da-ar da-ar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

maintenance Internal maintenance work that shouldn't appear in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create Github Workflow for Static & Spec Tests

3 participants

@sanfrancrisko @jpogran @da-ar