Fix(spec): Remove obsolete version from docker-compose.yml #3397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
This PR removes the obsolete
versionattribute from the top of thespec/docker-compose.ymlfile. This attribute is no longer required by modern versions of Docker Compose and was producing a warning message when runningdocker compose up.Related Issues
Important Note for Reviewers
While trying to test this change, I discovered that the developer environment build is currently failing due to an expired GPG key for the Puppet 6 repository.
This PR does not fix that issue, but I have opened a separate bug report for it here: [#3396]
The CI build for this PR will likely fail because of that unrelated error.