-
Notifications
You must be signed in to change notification settings - Fork 250
Add documentation about RootDirectory #15617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Your site preview for commit 7a5f237 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-15617-7a5f237d.s3-website.us-west-2.amazonaws.com. |
Your site preview for commit 45d109a is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-15617-45d109ad.s3-website.us-west-2.amazonaws.com. |
Your site preview for commit 4e344a8 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-15617-4e344a88.s3-website.us-west-2.amazonaws.com. |
Your site preview for commit bd09905 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-15617-bd099051.s3-website.us-west-2.amazonaws.com. |
@@ -0,0 +1 @@ | |||
FROM nginx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing newline.
@@ -0,0 +1,8 @@ | |||
module awsx-root-directory-go | |||
|
|||
go 1.21.12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this use a more up to date version of Go and the SDK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I picked the oldest version of the SDK that supported RootDir
@@ -0,0 +1 @@ | |||
FROM nginx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing newline.
@@ -8,7 +8,7 @@ menu: | |||
iac: | |||
name: Projects | |||
parent: iac-concepts | |||
weight: 20 | |||
weight: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious why this change? Is it intended in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No... not sure how that changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Broke up sentence for readability
|
||
You can get the directory containing the `Pulumi.yaml` file, which may differ from your working directory if it specified a `main` option (see [main attribute](/docs/reference/pulumi-yaml/#attributes)), with the `ProjectDirectory` function. | ||
|
||
The path returned will be an absolute path, but if using this in resource properties you'll want to make sure it's made relative to the working directory to prevent diffs from running the project on multiple machines with different roots. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The path returned will be an absolute path, but if using this in resource properties you'll want to make sure it's made relative to the working directory to prevent diffs from running the project on multiple machines with different roots. | |
The path returned is an absolute path. When using this in resource properties, ensure it's relative to the working directory. This prevents diffs from running the project on multiple machines with different roots. |
Just waiting for some releases for dotnet/nodejs so I can get their examples written up before merging this. |
Your site preview for commit 73b51f6 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-15617-73b51f6b.s3-website.us-west-2.amazonaws.com. |
Your site preview for commit b8a3e98 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-15617-b8a3e981.s3-website.us-west-2.amazonaws.com. |
Your site preview for commit 6b47a65 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-15617-6b47a657.s3-website.us-west-2.amazonaws.com. |
Test is failing because its still on pulumi 3.187 and needs 3.188. I think github images should update at some point to fix that. |
Or we could update the workflow's use of |
@pulumi/docs you ok with that? Feels reasonable for us to always be using the latest, even if that means sometimes having to download it rather than using what's on the GitHub runners ready installed. |
Sounds fine to me but I'd want @thoward to chime in, too. |
We are good with pinning to latest! |
Your site preview for commit 1be5d9a is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-15617-1be5d9ab.s3-website.us-west-2.amazonaws.com. |
Update the project concept page to have a section about getting paths relative to the root directory (the one containing the Pulumi.yaml)