-
Notifications
You must be signed in to change notification settings - Fork 55
Add errors for nonexistend include directory or missing path dependency #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
fischeti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we already talked about this, and I just wanted to write down a current issue:
Bender does not consider targets correctly. For instance, an include directory that is guarded by a target and does not exists (yet):
- target: missing_folder
include_dirs:
- missing_folder/include
files:
- missing_folder/my_module.svthrows an error at the moment even if missing_folder is not specified as a target
3583818 to
82177c1
Compare
82177c1 to
9efc21b
Compare
|
I adjusted the internals to only error if the missing include_directory is actually required 👍 |
fischeti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should work now as intended. I still get an error from the snitch_cluster dependency due to this:
Whi can/should be fixed in the snitch cluster🤓
|
As far as I understand, there is no inherent harm in including a non-existent directory for any downstream tool, although it is bad practice, unlike if a file doesn't exist. Therefore, I think it makes the most sense to convert this error into a warning, not an error. |
No description provided.