Skip to content

Conversation

@mrogenmoserTT
Copy link
Contributor

No description provided.

@micprog micprog requested a review from fischeti November 7, 2025 12:29
Copy link
Contributor

@fischeti fischeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we already talked about this, and I just wanted to write down a current issue:

Bender does not consider targets correctly. For instance, an include directory that is guarded by a target and does not exists (yet):

  - target: missing_folder
    include_dirs:
      - missing_folder/include
    files:
      - missing_folder/my_module.sv

throws an error at the moment even if missing_folder is not specified as a target

@mrogenmoserTT
Copy link
Contributor Author

I adjusted the internals to only error if the missing include_directory is actually required 👍

Copy link
Contributor

@fischeti fischeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should work now as intended. I still get an error from the snitch_cluster dependency due to this:

https://github.com/pulp-platform/snitch_cluster/blob/5b2fccd96c42812774c20ab2f9b811e164809789/Bender.yml#L38

Whi can/should be fixed in the snitch cluster🤓

@micprog
Copy link
Member

micprog commented Nov 21, 2025

As far as I understand, there is no inherent harm in including a non-existent directory for any downstream tool, although it is bad practice, unlike if a file doesn't exist. Therefore, I think it makes the most sense to convert this error into a warning, not an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants