Skip to content

Also resolve path of src/href attributes. #1553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Also resolve path of src/href attributes. #1553

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d19fb61
Resolve path of src/href attributes.
mauvm Jun 10, 2014
474b980
Removed quotes twice, oops.
mauvm Jun 10, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions lib/parser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ var path = require('path');
var constantinople = require('constantinople');
var parseJSExpression = require('character-parser').parseMax;
var extname = path.extname;
var isPathAttribute = /^src|href$/i;

/**
* Initialize `Parser` with the given input `str` and `filename`.
Expand Down Expand Up @@ -472,6 +473,29 @@ Parser.prototype = {
return path;
},

/**
* Resolves src/href attribute paths
*
* @param {Object} attr
* @api private
*/

resolveAttributePath: function (attr) {
var val = attr.val;

if (attr.escaped) {
// Remove quotes (dirty)
val = val.substr(1, -1);
}

attr.val = this.resolvePath(val, 'src/href attributes');

if (attr.escaped) {
// Add quotes again (dirty)
attr.val = '"' + attr.val + '"';
}
},

/**
* 'extends' name
*/
Expand Down Expand Up @@ -756,6 +780,9 @@ Parser.prototype = {
if (tok.selfClosing) tag.selfClosing = true;

for (var i = 0; i < attrs.length; i++) {
if (isPathAttribute.test(attrs[i].name)) {
this.resolveAttributePath(attrs[i]);
}
tag.setAttribute(attrs[i].name, attrs[i].val, attrs[i].escaped);
}
continue;
Expand Down