-
Notifications
You must be signed in to change notification settings - Fork 802
Modified required grants in README.md #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
README.md
Outdated
|
|
||
| [pth]:https://www.percona.com/doc/percona-toolkit/2.2/pt-heartbeat.html | ||
|
|
||
| Please remind to add the following grant: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about: "You will need to grant the exporter access to the heartbeat table:"
|
I have a vague recollection that SELECT was required on |
|
I might be missing something but I don't think that's the case: |
|
I don't mean that the query reference it directly, I meant that there was additional access control under the covers in MySQLd that required a broad SELECT. |
|
👍 got it. Unfortunately without integration tests running for all the supported MySQL versions I'm not sure how we can verify it. |
|
Ah, #153 |
|
@brian-brazil Yea, that's the one. We still support MySQL 5.1, and |
|
Since this won't work on older versions, I think we have to close this for now. |
After reviewing the collectors code I think we can reduce the scope of the MySQL grants to strictly mentions what it needs to run.
I'm not sure we really need
GRANT SELECT ON `information_schema`.* TO 'exporter'@'localhost';as for InnoDB tables it should be indirectly granted by the
PROCESSprivilege (at least on MySQL 5.7+).