Skip to content

minor refactor of replaceInvalidRune() in bridge.go #1897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2025
Merged

minor refactor of replaceInvalidRune() in bridge.go #1897

merged 1 commit into from
Oct 30, 2025
+37 −2

Conversation

@karthikkondapally
Copy link
Contributor

  • Added testcase for replaceInvalidRune in bridge.go
  • Minor Todo to apply De Morgan's law

@karthikkondapally
Copy link
Contributor Author

@kakkoyun

@bwplotka bwplotka merged commit 23c8ee1 into prometheus:main Oct 30, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kakkoyun kakkoyun kakkoyun approved these changes

@bwplotka bwplotka bwplotka approved these changes

@ArthurSens ArthurSens Awaiting requested review from ArthurSens ArthurSens is a code owner

@vesari vesari Awaiting requested review from vesari vesari is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@karthikkondapally @kakkoyun @bwplotka