[kube-state-metrics] Fix probes when kubeRBACProxy is enabled #5858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 3, 2025 19:14
This change add .Values.kubeRBACProxy.ignoreProbePaths to allow the kube-state-metrics readinessProbe and livenessProbe work properly when kubeRBACProxy is enabled Signed-off-by: Hendrik Ferber <[email protected]>
Signed-off-by: Hendrik Ferber <[email protected]>
HaveFun83
force-pushed
the
fix-kube-rbac-proxy-probe
branch
from
3b87cb1 to
a63c75d
Compare
HaveFun83
changed the title
HaveFun83
changed the title
HaveFun83
changed the title
Contributor
Author
|
@dotdc Better late then never 😃 Can you have a look please? |
3 tasks
Contributor
Author
|
@dotdc @mrueg @tariq1890 |
Contributor
Author
|
bump any news here? |
Member
|
With v2.16.0, I introduced an auth-filter https://github.com/kubernetes/kube-state-metrics/tree/f421b9a69a08f3009b959c81f08749176996998a/docs#protecting-metrics-endpoints Could we look into obsoleting the use of kube-rbac-proxy by using this auth-filter option? That would simplify the chart. |
Contributor
Author
|
can we merge this and simplify the chart in another PR? |
Contributor
Author
|
@mrueg |
Signed-off-by: David Calvert <[email protected]>
Member
|
I'm fine with that, I just don't use kube-rbac-proxy, so I won't be able to test this change. |
Member
Same for me. |
Contributor
Author
|
Thanks a lot guys ❤️ |
KyriosGN0
pushed a commit
to KyriosGN0/prom-helm-charts
that referenced
this pull request
Aug 20, 2025
…heus-community#5858) Signed-off-by: Hendrik Ferber <[email protected]> Signed-off-by: David Calvert <[email protected]> Co-authored-by: Hendrik Ferber <[email protected]> Co-authored-by: David Calvert <[email protected]>
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)This change add .Values.kubeRBACProxy.ignoreProbePaths to allow the kube-state-metrics readinessProbe and livenessProbe work properly when kubeRBACProxy is enabled
Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])