Skip to content

Conversation

@sunjayBhatia
Copy link
Member

@sunjayBhatia sunjayBhatia commented Dec 8, 2022

No description provided.

@sunjayBhatia sunjayBhatia requested a review from a team as a code owner December 8, 2022 22:00
@sunjayBhatia sunjayBhatia requested review from stevesloka and tsaarni and removed request for a team December 8, 2022 22:00
@sunjayBhatia sunjayBhatia added the release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. label Dec 8, 2022
@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #4913 (9e5b575) into main (41f663e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4913      +/-   ##
==========================================
+ Coverage   76.48%   76.50%   +0.01%     
==========================================
  Files         140      140              
  Lines       16750    16760      +10     
==========================================
+ Hits        12812    12822      +10     
  Misses       3688     3688              
  Partials      250      250              
Impacted Files Coverage Δ
internal/dag/gatewayapi_processor.go 96.91% <100.00%> (+0.02%) ⬆️
internal/gatewayapi/helpers.go 84.95% <100.00%> (+0.41%) ⬆️

@sunjayBhatia sunjayBhatia marked this pull request as draft December 8, 2022 22:21
@sunjayBhatia
Copy link
Member Author

Also blocked on kubernetes-sigs/gateway-api#1591

@sunjayBhatia sunjayBhatia force-pushed the enable-HTTPRouteInvalidParentRefNotMatchingListenerPort-test branch 2 times, most recently from 55a4421 to 6d77232 Compare December 14, 2022 22:42
@sunjayBhatia sunjayBhatia changed the base branch from dev-gwapi-0.6 to main December 14, 2022 22:43
@sunjayBhatia sunjayBhatia force-pushed the enable-HTTPRouteInvalidParentRefNotMatchingListenerPort-test branch from 6d77232 to ad3bf50 Compare December 14, 2022 22:44
@sunjayBhatia
Copy link
Member Author

blocked on the 0.6.0 release now

@sunjayBhatia sunjayBhatia force-pushed the enable-HTTPRouteInvalidParentRefNotMatchingListenerPort-test branch from ad3bf50 to 70e3d33 Compare December 14, 2022 23:53
Use NoMatchingParent reason when sectionname/port don't match

Signed-off-by: Sunjay Bhatia <[email protected]>
@sunjayBhatia sunjayBhatia force-pushed the enable-HTTPRouteInvalidParentRefNotMatchingListenerPort-test branch from 70e3d33 to 9e5b575 Compare December 21, 2022 19:30
@sunjayBhatia sunjayBhatia changed the title Enable HTTPRouteInvalidParentRefNotMatchingListenerPort test Gateway conformance: Enable HTTPRouteInvalidParentRefNotMatchingListenerPort test Dec 21, 2022
@sunjayBhatia sunjayBhatia marked this pull request as ready for review December 21, 2022 19:31
@sunjayBhatia sunjayBhatia requested a review from skriss December 21, 2022 19:31
Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sunjayBhatia sunjayBhatia merged commit fb564fc into projectcontour:main Dec 21, 2022
@sunjayBhatia sunjayBhatia deleted the enable-HTTPRouteInvalidParentRefNotMatchingListenerPort-test branch December 21, 2022 20:40
yangyy93 pushed a commit to projectsesame/contour that referenced this pull request Feb 16, 2023
…nerPort test (projectcontour#4913)

Use NoMatchingParent reason when sectionname/port don't match

Signed-off-by: Sunjay Bhatia <[email protected]>
Signed-off-by: yy <[email protected]>
yangyy93 pushed a commit to projectsesame/contour that referenced this pull request Feb 16, 2023
…nerPort test (projectcontour#4913)

Use NoMatchingParent reason when sectionname/port don't match

Signed-off-by: Sunjay Bhatia <[email protected]>
Signed-off-by: yy <[email protected]>
vmw-yingy pushed a commit to vmw-yingy/contour that referenced this pull request Feb 28, 2023
…nerPort test (projectcontour#4913)

Use NoMatchingParent reason when sectionname/port don't match

Signed-off-by: Sunjay Bhatia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants