-
Notifications
You must be signed in to change notification settings - Fork 701
Gateway conformance: Enable HTTPRouteInvalidParentRefNotMatchingListenerPort test #4913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sunjayBhatia
merged 2 commits into
projectcontour:main
from
sunjayBhatia:enable-HTTPRouteInvalidParentRefNotMatchingListenerPort-test
Dec 21, 2022
Merged
Gateway conformance: Enable HTTPRouteInvalidParentRefNotMatchingListenerPort test #4913
sunjayBhatia
merged 2 commits into
projectcontour:main
from
sunjayBhatia:enable-HTTPRouteInvalidParentRefNotMatchingListenerPort-test
Dec 21, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4913 +/- ##
==========================================
+ Coverage 76.48% 76.50% +0.01%
==========================================
Files 140 140
Lines 16750 16760 +10
==========================================
+ Hits 12812 12822 +10
Misses 3688 3688
Partials 250 250
|
Member
Author
|
Also blocked on kubernetes-sigs/gateway-api#1591 |
55a4421 to
6d77232
Compare
6d77232 to
ad3bf50
Compare
Member
Author
|
blocked on the 0.6.0 release now |
ad3bf50 to
70e3d33
Compare
Signed-off-by: Sunjay Bhatia <[email protected]>
Use NoMatchingParent reason when sectionname/port don't match Signed-off-by: Sunjay Bhatia <[email protected]>
70e3d33 to
9e5b575
Compare
skriss
approved these changes
Dec 21, 2022
Member
skriss
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
yangyy93
pushed a commit
to projectsesame/contour
that referenced
this pull request
Feb 16, 2023
…nerPort test (projectcontour#4913) Use NoMatchingParent reason when sectionname/port don't match Signed-off-by: Sunjay Bhatia <[email protected]> Signed-off-by: yy <[email protected]>
yangyy93
pushed a commit
to projectsesame/contour
that referenced
this pull request
Feb 16, 2023
…nerPort test (projectcontour#4913) Use NoMatchingParent reason when sectionname/port don't match Signed-off-by: Sunjay Bhatia <[email protected]> Signed-off-by: yy <[email protected]>
vmw-yingy
pushed a commit
to vmw-yingy/contour
that referenced
this pull request
Feb 28, 2023
…nerPort test (projectcontour#4913) Use NoMatchingParent reason when sectionname/port don't match Signed-off-by: Sunjay Bhatia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release-note/none-required
Marks a PR as not requiring a release note. Should only be used for very small changes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.