Update prost and tonic to latest major versions #827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
daviddrysdale
left a comment
daviddrysdale
left a comment
There was a problem hiding this comment.
If you apply the suggestions and rebase on current main, I think all of the CI failures except cargo deny should be fixed.
Thanks!
| # This file is automatically @generated by Cargo. | ||
| # It is not intended for manual editing. | ||
| version = 3 | ||
| version = 4 |
Collaborator
There was a problem hiding this comment.
Maybe leave this at 3 so the builds with older Rust versions still work?
|
|
||
| [build-dependencies] | ||
| prost-build = "^0.13" | ||
| prost-build = "^0.14" |
Collaborator
There was a problem hiding this comment.
Looks like the auto-generated code under proto/src/codegen needs to be regenerated after the upgrade. (IIRC you can trigger that by building with PROTOC pointing to a valid protoc.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.