A ref forwarding to two more SelectMenu components #957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Cole Bemis <[email protected]>
Bumps @primer/gatsby-theme-doctocat from 1.2.0 to 1.3.0. Signed-off-by: dependabot[bot] <[email protected]>
…er/gatsby-theme-doctocat-1.3.0 Bump @primer/gatsby-theme-doctocat from 1.2.0 to 1.3.0 in /docs
Add Gatsby installation to startup docs
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primer-components/ci5mfcrkb |
emplums
commented
Jan 6, 2021
index.d.ts
Outdated
| interface SelectMenuItemCommonProps extends CommonProps { | ||
| selected?: boolean; | ||
| selected?: boolean | ||
| ref?: React.RefObject<HTMLAnchorElement> | React.RefObject<HTMLDivElement> | null |
There was a problem hiding this comment.
Most of the time we expect people to use the default a tag on SelectMenu.Item, but in ✨ another project at GitHub ✨ folks are using the SelectMenu.Item as a button
colebemis
approved these changes
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ref forwarding to SelectMenu.Filter and SelectMenu.Item
Closes #949
Screenshots
Merge checklist
index.d.ts) if necessaryTake a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.