Upgrade React #942
Merged
Upgrade React #942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployment failed with the following error: |
emplums
commented
Dec 14, 2020
|
Deployment failed with the following error: |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primer-components/k52z651wn |
|
Note: I needed to remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the acceptable React version to be used as an external dependency to React
^17.0.0.I've also moved
reactfromdependenciestodevDependencies. Since it's marked as apeerDependencyit shouldn't be in regular deps. I don't think we realized this becauserollupis markingreactas external (preventing it to be bundled with the application).This change would require all applications using Primer React Components to upgrade to version 17 and should be released as a breaking change.
Open Questions
Should we allow versions above 16.8 still? I'm pretty sure because I added
capture: trueto the two document listeners in the library, we should see the same behavior in environments using^16.8.0and environments using^17.0.0. It still feels a little weird to allow either version, but because17.0.0is relatively new, I wouldn't want someone to be prevented from using PRC because another dependency in their application requires something below 17 🤔Closes #941
Screenshots
Please provide before/after screenshots for any visual changes
Merge checklist
index.d.ts) if necessaryTake a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.