Skip to content

Update Spinner.features.stories.tsx to no longer use styled-components #6486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 12, 2025

Conversation

llastflowers
Copy link
Contributor

Closes https://github.com/github/primer/issues/5637

Changelog

New

Added new CSS module

Changed

Changed Spinner.features.stories.tsx to no longer use styled-components

Removed

Removed anything associated with styled-components

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@llastflowers llastflowers self-assigned this Aug 6, 2025
@llastflowers llastflowers added skip changeset This change does not need a changelog integration-tests: skipped manually Changes in this PR do not require an integration test labels Aug 6, 2025

This comment was marked as resolved.

Copy link
Contributor

github-actions bot commented Aug 6, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 90.28 KB (0%)
packages/react/dist/browser.umd.js 90.44 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-6486 August 6, 2025 23:22 Inactive
@llastflowers llastflowers marked this pull request as ready for review August 6, 2025 23:23
@Copilot Copilot AI review requested due to automatic review settings August 6, 2025 23:23
@llastflowers llastflowers requested a review from a team as a code owner August 6, 2025 23:23
@llastflowers llastflowers requested a review from pksjce August 6, 2025 23:23
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes styled-components usage from the Spinner component's feature stories by replacing the Box component with a CSS module approach. The change aligns with the project's migration away from styled-components while maintaining the same visual layout and functionality.

  • Replaced Box component with a div element using CSS module classes
  • Created a new CSS module file to define the styling previously handled by the sx prop
  • Removed the Box import that is no longer needed

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/react/src/Spinner/Spinner.features.stories.tsx Replaced Box component with div and CSS module class, removed Box import
packages/react/src/Spinner/Spinner.features.stories.module.css Added new CSS module with flexbox styling equivalent to the previous sx prop

@llastflowers llastflowers requested a review from joshblack August 6, 2025 23:23
@llastflowers llastflowers added this pull request to the merge queue Aug 12, 2025
Merged via the queue into main with commit 799da70 Aug 12, 2025
43 checks passed
@llastflowers llastflowers deleted the llastflowers/5637/no-SC-Spinner-stories branch August 12, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: skipped manually Changes in this PR do not require an integration test skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants