-
Notifications
You must be signed in to change notification settings - Fork 625
Update Spinner.features.stories.tsx to no longer use styled-components #6486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes styled-components usage from the Spinner component's feature stories by replacing the Box component with a CSS module approach. The change aligns with the project's migration away from styled-components while maintaining the same visual layout and functionality.
- Replaced Box component with a div element using CSS module classes
- Created a new CSS module file to define the styling previously handled by the sx prop
- Removed the Box import that is no longer needed
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
packages/react/src/Spinner/Spinner.features.stories.tsx | Replaced Box component with div and CSS module class, removed Box import |
packages/react/src/Spinner/Spinner.features.stories.module.css | Added new CSS module with flexbox styling equivalent to the previous sx prop |
Closes https://github.com/github/primer/issues/5637
Changelog
New
Added new CSS module
Changed
Changed
Spinner.features.stories.tsx
to no longer use styled-componentsRemoved
Removed anything associated with styled-components
Rollout strategy
Testing & Reviewing
Merge checklist