Skip to content

Add stickyTop prop to PageLayout.Pane #2232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Aug 18, 2022
Merged

Add stickyTop prop to PageLayout.Pane #2232

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
515992a
Add stickyTop prop to PageLayout.Pane
broccolinisoup Aug 16, 2022
3d1f53b
update docs
broccolinisoup Aug 17, 2022
bc54d11
add changeset
broccolinisoup Aug 17, 2022
d06c1a7
Update stickyTop story
colebemis Aug 17, 2022
2d429d1
Allow stickyTop to accept a string
colebemis Aug 17, 2022
3919fdd
Update docs/content/PageLayout.mdx
broccolinisoup Aug 17, 2022
e4060b0
Update docs/content/PageLayout.mdx
broccolinisoup Aug 17, 2022
c433888
Merge branch 'main' into pagelayout-stickyTop-prop
broccolinisoup Aug 17, 2022
800b3ec
Update prop description on the docs
broccolinisoup Aug 17, 2022
d949608
Merge branch 'main' into pagelayout-stickyTop-prop
colebemis Aug 18, 2022
319f756
Add stickyTop example and prop docs
broccolinisoup Aug 18, 2022
753a6f1
Update SplitPageLayout example
colebemis Aug 18, 2022
0adf6b0
Fix code fence
colebemis Aug 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions src/PageLayout/PageLayout.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,20 +659,22 @@ NestedScrollContainer.argTypes = {
}
}

export const StickyPaneWithStickyTop: Story = args => (
export const CustomStickyHeader: Story = args => (
// a box to create a sticky top element that will be on the consumer side and outside of the PageLayout component
<Box>
<Box
height={args.stickyTop}
width="100%"
border="1px solid"
borderColor="border.default"
sx={{position: 'sticky', top: '0', backgroundColor: 'canvas.subtle'}}
display="flex"
alignItems="center"
justifyContent="center"
sx={{
position: 'sticky',
top: 0,
height: args.stickyTop,
display: 'grid',
placeItems: 'center',
backgroundColor: 'canvas.subtle',
borderBottom: '1px solid',
borderColor: 'border.default'
}}
>
<Heading>Sticky top content</Heading>
Custom sticky header
Copy link
Member Author

@broccolinisoup broccolinisoup Aug 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah this is very explanatory. Thanks for updating it!

</Box>
<PageLayout rowGap="none" columnGap="none" padding="none" containerWidth="full">
<PageLayout.Content padding="normal" width="large">
Expand All @@ -689,7 +691,7 @@ export const StickyPaneWithStickyTop: Story = args => (
))}
</Box>
</PageLayout.Content>
<PageLayout.Pane position="start" padding="normal" divider="line" stickyTop={100} sticky>
<PageLayout.Pane position="start" padding="normal" divider="line" sticky stickyTop={args.stickyTop}>
<Box sx={{display: 'grid', gap: 3}}>
{Array.from({length: args.numParagraphsInPane}).map((_, i) => (
<Box key={i} as="p" sx={{margin: 0}}>
Expand All @@ -708,7 +710,7 @@ export const StickyPaneWithStickyTop: Story = args => (
</Box>
)

StickyPaneWithStickyTop.argTypes = {
CustomStickyHeader.argTypes = {
sticky: {
type: 'boolean',
defaultValue: true
Expand Down