-
Notifications
You must be signed in to change notification settings - Fork 646
Include React 18 in peerDependencies #2205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 405f039 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I assume this PR adds support for React 18? Is there anything blocking from merging it? |
|
As per #2202 (comment), React 18 is not yet supported, but there are plans to support it in the future. It is my understanding that #2196 is one of them. If the next release includes support for React 18, this PR could be merged as well. |
|
It says there's an internal issue. Why can't there be a public issue I could subscribe to in order to find out when React 18 will be supported? |
|
yeah, the issue related with react 18 should be tracked. |
|
Apologies, I still don't understand. Is there a public issue I can subscribe to in order to get notified when React 18 support has been implemented? Which one is it? |
siddharthkp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi!
Sorry for the delay, we are still collecting all the compatibility issues with React 18.
Meanwhile, I think this is a pretty safe change to ship 👍
|
Added to tracking issue for next release: #2234 (we typically publish a new patch/minor release roughly every 10 days) |
It includes react 18 in peerDependencies as an addition to #2196 changes.
Screenshots
Please provide before/after screenshots for any visual changes
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.