Skip to content

Conversation

@okuryu
Copy link
Contributor

@okuryu okuryu commented Aug 2, 2022

It includes react 18 in peerDependencies as an addition to #2196 changes.

Screenshots

Please provide before/after screenshots for any visual changes

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@okuryu okuryu requested review from a team and rezrah August 2, 2022 01:20
@changeset-bot
Copy link

changeset-bot bot commented Aug 2, 2022

🦋 Changeset detected

Latest commit: 405f039

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tonimelisma
Copy link

I assume this PR adds support for React 18? Is there anything blocking from merging it?

@okuryu
Copy link
Contributor Author

okuryu commented Aug 13, 2022

As per #2202 (comment), React 18 is not yet supported, but there are plans to support it in the future. It is my understanding that #2196 is one of them. If the next release includes support for React 18, this PR could be merged as well.

@tonimelisma
Copy link

It says there's an internal issue. Why can't there be a public issue I could subscribe to in order to find out when React 18 will be supported?

@okuryu
Copy link
Contributor Author

okuryu commented Aug 15, 2022

yeah, the issue related with react 18 should be tracked.

@tonimelisma
Copy link

Apologies, I still don't understand. Is there a public issue I can subscribe to in order to get notified when React 18 support has been implemented? Which one is it?

Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!

Sorry for the delay, we are still collecting all the compatibility issues with React 18.

Meanwhile, I think this is a pretty safe change to ship 👍

@siddharthkp siddharthkp temporarily deployed to github-pages August 16, 2022 11:02 Inactive
@siddharthkp siddharthkp merged commit 4badb57 into primer:main Aug 16, 2022
@primer-css primer-css mentioned this pull request Aug 16, 2022
@siddharthkp
Copy link
Member

siddharthkp commented Aug 16, 2022

Added to tracking issue for next release: #2234 (we typically publish a new patch/minor release roughly every 10 days)

@okuryu okuryu deleted the peerDeps branch August 17, 2022 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants