Skip to content

Menu: Fix typeahead with leading visuals #1914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 2, 2022
Merged

Menu: Fix typeahead with leading visuals #1914

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bce63f3
Trim textContent to ignore leading visual
siddharthkp Mar 1, 2022
ee11efa
Create slimy-garlics-wash.md
siddharthkp Mar 1, 2022
aadb472
Menu → ActionMenu
siddharthkp Mar 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/slimy-garlics-wash.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Menu: Fix typeahead with leading visuals
Copy link
Contributor

@colebemis colebemis Mar 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this say ActionMenu?

2 changes: 1 addition & 1 deletion src/hooks/useTypeaheadFocus.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export const useTypeaheadFocus = (open: boolean, providedRef?: React.RefObject<H

const focusNextMatch = () => {
const itemsStartingWithKey = focusableItems.filter(item => {
return item.textContent?.toLowerCase().startsWith(query)
return item.textContent?.toLowerCase().trim().startsWith(query)
})

const currentActiveIndex = itemsStartingWithKey.indexOf(activeElement)
Expand Down