ThemeProvider: Fix theming with SSR with CSRF safe approach #1913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 49d2970 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
siddharthkp
changed the title
siddharthkp
changed the title
Contributor
size-limit report 📦
|
pksjce
reviewed
Mar 1, 2022
colebemis
reviewed
Mar 4, 2022
colebemis
approved these changes
Mar 4, 2022
Contributor
colebemis
left a comment
colebemis
left a comment
There was a problem hiding this comment.
Looks good! This is a clever trick 😅
Co-authored-by: Cole Bemis <[email protected]>
This was referenced Mar 7, 2022
Merged
siddharthkp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #1868, the approach I chose relied on injecting an inline script to set a variable. This doesn't work in github/docs-internal because secure applications prevent executing inline scripts injected in the DOM 😇
Inspired by
__NEXT_DATA__from next.js, I've changed the implementation to inject a<script type="application/json">instead of<script type="text/javascript">.Tested with docs-internal, it works!