-
Notifications
You must be signed in to change notification settings - Fork 645
Merge DropdownMenu2 into ActionMenu2 #1848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
siddharthkp
merged 17 commits into
main
from
siddharth/merge-dropdownmenu-into-actionmenu
Feb 21, 2022
Merged
Changes from 11 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
c5eb570
merge docs
siddharthkp 74fa5ad
merge stories/examples
siddharthkp e2513ea
merge stories/fixtures
siddharthkp b53f87a
move itemRole to item and delete dropdonwmenu
siddharthkp 24c1cbf
add test for single selection
siddharthkp 25aede5
Add tests for additional use cases
siddharthkp ae67737
delete outdated snapshot
siddharthkp 7f5f07a
Merge branch 'main' into siddharth/merge-dropdownmenu-into-actionmenu
siddharthkp 766c2b1
add changeset
siddharthkp 1e90bda
fix group roles based on latest discussion
siddharthkp 9a4706d
Revert "fix group roles based on latest discussion"
siddharthkp 0c15a11
Update docs/content/drafts/ActionMenu2.mdx
siddharthkp 3d0a2a0
Merge branch 'main' into siddharth/merge-dropdownmenu-into-actionmenu
siddharthkp 21b06c7
use merged ActionMenu instead of Dropdown in Overlay
siddharthkp d5d3401
bring back DropdownMenu2 part 1/2
siddharthkp 82535fb
bring back DropdownMenu2 part 2/2
siddharthkp 5654f8f
Merge branch 'main' into siddharth/merge-dropdownmenu-into-actionmenu
siddharthkp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@primer/react': patch | ||
| --- | ||
|
|
||
| Merges drafts/DropdownMenu2 into drafts/ActionMenu2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.