Skip to content

Remove unnecessary label title #1826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 15, 2022
Merged

Remove unnecessary label title #1826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8310a0c
remove label title
PeterYangIO Jan 29, 2022
0240e96
add changeset
PeterYangIO Jan 29, 2022
707d121
Merge branch 'main' into users/peteryangio/remove-label-title
PeterYangIO Jan 31, 2022
a5fc3b1
Merge branch 'main' into users/peteryangio/remove-label-title
PeterYangIO Feb 9, 2022
62f7b2b
Merge branch 'main' into users/peteryangio/remove-label-title
PeterYangIO Feb 9, 2022
77e3484
Merge branch 'main' into users/peteryangio/remove-label-title
PeterYangIO Feb 9, 2022
3fad711
Merge branch 'main' into users/peteryangio/remove-label-title
rezrah Feb 14, 2022
1daaa0e
Merge branch 'main' into users/peteryangio/remove-label-title
rezrah Feb 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/slow-fireants-shave.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': patch
---

Remove unnecessary "required field" label title in favor for native `required` input attribute
1 change: 0 additions & 1 deletion src/_InputLabel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ const InputLabel: React.FC<Props & SxProp> = ({children, disabled, required, vis
isVisible={!visuallyHidden}
as="label"
htmlFor={htmlFor}
title={required ? 'required field' : undefined}
sx={{
fontWeight: 'bold',
fontSize: 1,
Expand Down
2 changes: 1 addition & 1 deletion src/__tests__/InputField.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ describe('InputField', () => {
</SSRProvider>
)

const input = getByRole('textbox')
const input = getByRole('textbox', {name: TEXTINPUTFIELD_LABEL_TEXT})

expect(input.getAttribute('required')).not.toBeNull()
})
Expand Down