Normalize color data to lowercase hex #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6b26226 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
simurai
approved these changes
Jul 21, 2022
Contributor
simurai
left a comment
simurai
left a comment
There was a problem hiding this comment.
Thanks. 🙇 I think that's a good idea to make the hex values use the same format. 👍
Contributor
If I remember correctly, it has to do with "change to vertical list once the line gets too long". Maybe the linter complains otherwise. |
Merged
Contributor
Author
|
Understood, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't matter as much in code, but kinda stood out to me on the Primer website.
P.s. is there a reason some color arrays are in a single line and others in a vertical list, or is that random (different contributors)?