Skip to content

Conversation

@simurai
Copy link
Contributor

@simurai simurai commented Nov 30, 2021

This addresses https://github.com/github/design-infrastructure/discussions/1439#discussioncomment-1714926 by improving contrast of that expander icon:

Before

Screen Shot 2021-11-30 at 17 26 41

After

Light High Contrast Dark Dimmed
Screen Shot 2021-11-30 at 17 03 35 Screen Shot 2021-11-30 at 17 02 09
fg.onEmphasis fg.default

@changeset-bot
Copy link

changeset-bot bot commented Nov 30, 2021

🦋 Changeset detected

Latest commit: 028d9fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Nov 30, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primitives/61q8MYPzA1iZ8BUjrjVFTZkQtZFM
✅ Preview: https://primitives-git-diff-blob-expander-icon-primer.vercel.app

@github-actions
Copy link
Contributor

github-actions bot commented Nov 30, 2021

Variables changed
--- base/dist/scss/colors/_light_high_contrast.scss	2021-11-30 08:25:06.964686641 +0000
+++ dist/scss/colors/_light_high_contrast.scss	2021-11-30 08:24:56.672464660 +0000
@@ -16,3 +16,3 @@
     --color-diff-blob-hunk-num-bg: #9cd7ff;
-    --color-diff-blob-expander-icon: #0E1116;
+    --color-diff-blob-expander-icon: #ffffff;
     --color-diff-blob-selected-line-highlight-mix-blend-mode: multiply;

@simurai simurai marked this pull request as ready for review November 30, 2021 08:28
@simurai simurai requested a review from a team as a code owner November 30, 2021 08:28
@simurai simurai requested review from a team, jonrohan and rezrah November 30, 2021 08:28
@simurai simurai enabled auto-merge (squash) November 30, 2021 08:28
@simurai simurai merged commit 46d2c1e into main Nov 30, 2021
@simurai simurai deleted the diff-blob-expander-icon branch November 30, 2021 11:23
@primer-css primer-css mentioned this pull request Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants