Skip to content
This repository was archived by the owner on Jul 7, 2025. It is now read-only.

Update Octicons Description #457

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JoshBowdenConcepts
Copy link
Contributor

Summary

There was agreed upon changes to the description of Octicons. I have updated that here.

@JoshBowdenConcepts JoshBowdenConcepts marked this pull request as ready for review March 31, 2023 12:36
@JoshBowdenConcepts JoshBowdenConcepts requested a review from a team as a code owner March 31, 2023 12:36
Comment on lines +9 to +11
Primer Octicons are GitHub’s open source library of icons for GitHub UI. These are visual metaphors intended to serve as a visual language. If you are looking for brand and marketing logos and visuals, see <a href="/foundations/icons/octovisuals">Octovisuals</a>.

<a href="/foundations/icons/design-guidelines">See Design and usage guidelines</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use markdown links here?

Suggested change
Primer Octicons are GitHub’s open source library of icons for GitHub UI. These are visual metaphors intended to serve as a visual language. If you are looking for brand and marketing logos and visuals, see <a href="/foundations/icons/octovisuals">Octovisuals</a>.
<a href="/foundations/icons/design-guidelines">See Design and usage guidelines</a>
Primer Octicons are GitHub’s open source library of icons for GitHub UI. These are visual metaphors intended to serve as a visual language. If you are looking for brand and marketing logos and visuals, see [Octovisuals](/foundations/icons/octovisuals).
[See Design and usage guidelines](/foundations/icons/design-guidelines)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoshBowdenConcepts I was just cleaning up the PRs and saw that this one is pending your input 🙂

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants